Bug 114235

Summary: [patch] Allow dynamic linking in sysutils/env4801
Product: Ports & Packages Reporter: Henrik Brix Andersen <henrik>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me CC: pmh
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
env4801.diff none

Description Henrik Brix Andersen 2007-07-03 11:10:02 UTC 
The sysutils/env4801 utility is always statically linked. This causes
problems when the utility is compiled and linked on a system with a
libc optimized for e.g. prescott (a build box) and later deployed on
an i586 net4801.

Fix: The patch below adds an option for linking env4801 dynamically instead
of statically.

	
How-To-Repeat: 	

# cd /usr/ports/sysutils/env4801
# make install clean
# ldd /usr/local/sbin/env4801
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-07-03 11:10:11 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 2 Patrick M. Hausen 2007-07-03 19:01:43 UTC 
Hi!

Am 03.07.2007 um 12:10 schrieb Edwin Groothuis:

> Maintainer of sysutils/env4801,
>
> Please note that PR ports/114235 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/114235

I fully approve and I'd like to ask Henrik, why not make dynamic
linking the default? Seems like the right thing [tm] to me.

Kind regards,
Patrick
Comment 3 Henrik Brix Andersen 2007-07-03 19:29:44 UTC 
Hi,

On Tue, Jul 03, 2007 at 08:01:43PM +0200, Patrick M. Hausen wrote:
> I fully approve and I'd like to ask Henrik, why not make dynamic
> linking the default? Seems like the right thing [tm] to me.


I thought about that, but thought it was best not to change current
behaviour. After all, the author of env4801 clearly intended it to be
linked statically. If you think otherwise, feel free to change the
option to a default of 'Off'.

Regards,
Brix
-- 
Henrik Brix Andersen <henrik@brixandersen.dk>
Comment 4 Erwin Lansing freebsd_committer freebsd_triage 2007-07-03 19:49:37 UTC 
State Changed
From-To: feedback->closed

Committed, thanks!
Comment 5 dfilter service freebsd_committer freebsd_triage 2007-07-03 19:49:40 UTC 
erwin       2007-07-03 18:49:35 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/env4801     Makefile 
  Log:
  Add an option to build a dynamically linked binary, defaulting
  to off
  
  PR:             114235
  Submitted by:   Henrik Brix Andersen <henrik@brixandersen.dk>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.5       +11 -1     ports/sysutils/env4801/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"