Bug 115677

Summary: [PATCH] Don't depend on XPM for graphics/php5-gd
Product: Ports & Packages Reporter: Xin LI <delphij>
Component: Individual Port(s)Assignee: Alex Dupre <ale>
Status: Closed FIXED    
Severity: Affects Only Me CC: ale
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-php5-gd
none
php5-gd-noxpm.diff none

Description Xin LI freebsd_committer freebsd_triage 2007-08-21 10:10:08 UTC 
	The php5-gd extension depends on XPM by default, while
	graphics/gd does not.

	With this inconsistency, php5-gd extension would install
	XPM, while it does not actually use it.

Fix: This is not a perfect solution, it simply utilize the flags
	that is employed by gd to distinguish whether we wanted XPM;
	a more better way might be to use gdlib-config --features,
	but that would be very slow, and we really need to take care
	about whether we have XPM feature installed.
How-To-Repeat: 	cd /usr/ports/graphics/php5-gd
	make -V LIB_DEPENDS | grep --color Xpm.4

	cd /usr/ports/graphics/gd
	make -V LIB_DEPENDS | grep --color Xpm.4
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-08-21 10:10:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ale

Over to maintainer
Comment 2 Xin LI 2007-08-21 16:32:07 UTC 
Just for the record.  I think I have somewhat misunderstood the 
relationship between graphics/php5-gd and graphics/gd, the former does 
not depend on the latter.  However, I would say that it would be better 
if we can get rid of the XPM dependency, which provided some function 
that is not very useful for common deployment.

Please consider the proposed patch, or provide an OPTION menu for php5-gd.

Cheers,
Comment 3 Xin LI 2007-08-21 16:59:46 UTC 
Here is a new patch which makes use of the OPTION framework, and gaves 
the user an opportunity to enable XPM if they really need it.

Cheers,
Comment 4 Alex Dupre freebsd_committer freebsd_triage 2007-09-13 16:05:21 UTC 
State Changed
From-To: open->closed

The current behavior is correct. You cannot check for XPM after bsd.port.pre.mk inclusion. 
Moreover, the t1lib dependency already add xpm, unless you define WITHOUT_X11.