Bug 115678
| Summary: | All tcp/udp packet have wrong checksums on -current | ||
|---|---|---|---|
| Product: | Base System | Reporter: | Yuri Bushmelev <jay-dev> |
| Component: | kern | Assignee: | Bjoern A. Zeeb <bz> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | 7.0-CURRENT | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
Yuri Bushmelev
2007-08-21 10:30:17 UTC
bz 2007-10-20 22:18:42 UTC
FreeBSD src repository
Modified files:
sys/i386/i386 in_cksum.c
sys/i386/include in_cksum.h
Log:
Fold multiple asm statements into one so that the compiler at a certain
optimization level (-march=pentium-mmx for example) does not insert
intermediate ops which would trash the carry.
Change both sys/i386/i386/in_cksum.c[1] and sys/i386/include/in_cksum.h.
To my best understanding the same problem was addressed in rev. 1.16
of src/sys/i386/include/in_cksum.h for just a single function 3y ago.
Reviewed by: jhb
Submitted by: Zhouyi ZHOU <zhouzhouyi FreeBSD.org> (intial version of [1])
MFC after: 5 days
PR: 115678, 69257
Revision Changes Path
1.29 +77 -43 src/sys/i386/i386/in_cksum.c
1.18 +14 -7 src/sys/i386/include/in_cksum.h
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->feedback Committed a patch to HEAD, needs review if it helps. Responsible Changed From-To: freebsd-bugs->bz Committed a patch to HEAD, keep trak of this. On Sat, 20 Oct 2007, bz@FreeBSD.org wrote: Hi, could you try the changes that came with this commit http://docs.freebsd.org/cgi/mid.cgi?200710202218.l9KMIgpL068209 and let me know if it helps you? -- Bjoern A. Zeeb bzeeb at Zabbadoz dot NeT Software is harder than hardware so better get it right the first time. > On Sat, 20 Oct 2007, bz@FreeBSD.org wrote: > > Hi, > > could you try the changes that came with this commit > > http://docs.freebsd.org/cgi/mid.cgi?200710202218.l9KMIgpL068209 > > and let me know if it helps you? Sorry, I can't try this changes right now.. This installation was downgraded to 6-STABLE and I have no test machine now. I'll try this within next month. -- Yuri Bushmelev State Changed From-To: feedback->closed Sumbmitter, in private mail, said it's fine to close it. He'll come back and re-open it in case the problem still exists once he can test it. bz 2007-10-26 07:15:04 UTC
FreeBSD src repository
Modified files: (Branch: RELENG_7)
sys/i386/i386 in_cksum.c
sys/i386/include in_cksum.h
Log:
MFC: rev. 1.29 sys/i386/i386/in_cksum.c
rev. 1.18 sys/i386/include/in_cksum.h
Fold multiple asm statements into one so that the compiler at a certain
optimization level (-march=pentium-mmx for example) does not insert
intermediate ops which would trash the carry.
Change both sys/i386/i386/in_cksum.c[1] and sys/i386/include/in_cksum.h.
To my best understanding the same problem was addressed in rev. 1.16
of src/sys/i386/include/in_cksum.h for just a single function 3y ago.
Reviewed by: jhb
Submitted by: Zhouyi ZHOU <zhouzhouyi FreeBSD.org> (intial version of [1])
PR: 115678, 69257
Approved by: re (kensmith)
Revision Changes Path
1.28.10.1 +77 -43 src/sys/i386/i386/in_cksum.c
1.17.10.1 +14 -7 src/sys/i386/include/in_cksum.h
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
