Bug 116116

Summary: mktemp (3) re/move note
Product: Documentation Reporter: Oleg <oleg.dolgov>
Component: Books & ArticlesAssignee: Eitan Adler <eadler>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Oleg 2007-09-05 12:20:12 UTC
in BUGS section:

The implementation of these functions calls arc4random(3), which is not
reentrant.  You must provide your own locking around this and other con-
sumers of the arc4random(3) API.

IMHO need to clean this note, because mkstemp and others are thread-safe.
We can move it to arc4random(3) man page.
Comment 1 Eitan Adler freebsd_committer freebsd_triage 2012-02-23 02:53:37 UTC
Responsible Changed
From-To: freebsd-doc->eadler

I'll take it.
Comment 2 Eitan Adler freebsd_committer freebsd_triage 2012-03-03 19:36:30 UTC
State Changed
From-To: open->analyzed

awaiting approval
Comment 3 dfilter service freebsd_committer freebsd_triage 2012-03-04 16:44:18 UTC
Author: eadler
Date: Sun Mar  4 16:44:04 2012
New Revision: 232505
URL: http://svn.freebsd.org/changeset/base/232505

Log:
  Remove outdated comment of seven years
  
  PR:		docs/116116
  Approved by:	cperciva
  MFC after:	1 week

Modified:
  head/lib/libc/stdio/mktemp.3

Modified: head/lib/libc/stdio/mktemp.3
==============================================================================
--- head/lib/libc/stdio/mktemp.3	Sun Mar  4 16:41:07 2012	(r232504)
+++ head/lib/libc/stdio/mktemp.3	Sun Mar  4 16:44:04 2012	(r232505)
@@ -236,10 +236,3 @@ and the return status of the call should
 This will ensure that the program does not continue blindly
 in the event that an attacker has already created the file
 with the intention of manipulating or reading its contents.
-.Pp
-The implementation of these functions calls
-.Xr arc4random 3 ,
-which is not reentrant.
-You must provide your own locking around this and other consumers of the
-.Xr arc4random 3
-API.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 4 Eitan Adler freebsd_committer freebsd_triage 2012-03-04 21:23:06 UTC
State Changed
From-To: analyzed->patched

committed in r232505
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-03-19 01:56:35 UTC
Author: eadler
Date: Mon Mar 19 01:56:26 2012
New Revision: 233155
URL: http://svn.freebsd.org/changeset/base/233155

Log:
  MFC r232505:
  	Remove outdated comment of seven years
  
  PR:		docs/116116
  Approved by:	cperciva

Modified:
  stable/9/lib/libc/stdio/mktemp.3
Directory Properties:
  stable/9/lib/libc/   (props changed)

Modified: stable/9/lib/libc/stdio/mktemp.3
==============================================================================
--- stable/9/lib/libc/stdio/mktemp.3	Mon Mar 19 01:52:09 2012	(r233154)
+++ stable/9/lib/libc/stdio/mktemp.3	Mon Mar 19 01:56:26 2012	(r233155)
@@ -236,10 +236,3 @@ and the return status of the call should
 This will ensure that the program does not continue blindly
 in the event that an attacker has already created the file
 with the intention of manipulating or reading its contents.
-.Pp
-The implementation of these functions calls
-.Xr arc4random 3 ,
-which is not reentrant.
-You must provide your own locking around this and other consumers of the
-.Xr arc4random 3
-API.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-03-19 01:57:11 UTC
Author: eadler
Date: Mon Mar 19 01:56:52 2012
New Revision: 233156
URL: http://svn.freebsd.org/changeset/base/233156

Log:
  MFC r232505:
  	Remove outdated comment of seven years
  
  PR:		docs/116116
  Approved by:	cperciva

Modified:
  stable/8/lib/libc/stdio/mktemp.3
Directory Properties:
  stable/8/lib/libc/   (props changed)

Modified: stable/8/lib/libc/stdio/mktemp.3
==============================================================================
--- stable/8/lib/libc/stdio/mktemp.3	Mon Mar 19 01:56:26 2012	(r233155)
+++ stable/8/lib/libc/stdio/mktemp.3	Mon Mar 19 01:56:52 2012	(r233156)
@@ -236,10 +236,3 @@ and the return status of the call should
 This will ensure that the program does not continue blindly
 in the event that an attacker has already created the file
 with the intention of manipulating or reading its contents.
-.Pp
-The implementation of these functions calls
-.Xr arc4random 3 ,
-which is not reentrant.
-You must provide your own locking around this and other consumers of the
-.Xr arc4random 3
-API.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-03-19 01:57:24 UTC
Author: eadler
Date: Mon Mar 19 01:57:14 2012
New Revision: 233157
URL: http://svn.freebsd.org/changeset/base/233157

Log:
  MFC r232505:
  	Remove outdated comment of seven years
  
  PR:		docs/116116
  Approved by:	cperciva

Modified:
  stable/7/lib/libc/stdio/mktemp.3
Directory Properties:
  stable/7/lib/libc/   (props changed)

Modified: stable/7/lib/libc/stdio/mktemp.3
==============================================================================
--- stable/7/lib/libc/stdio/mktemp.3	Mon Mar 19 01:56:52 2012	(r233156)
+++ stable/7/lib/libc/stdio/mktemp.3	Mon Mar 19 01:57:14 2012	(r233157)
@@ -236,10 +236,3 @@ and the return status of the call should
 This will ensure that the program does not continue blindly
 in the event that an attacker has already created the file
 with the intention of manipulating or reading its contents.
-.Pp
-The implementation of these functions calls
-.Xr arc4random 3 ,
-which is not reentrant.
-You must provide your own locking around this and other consumers of the
-.Xr arc4random 3
-API.
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 8 Eitan Adler freebsd_committer freebsd_triage 2012-03-19 02:41:52 UTC
State Changed
From-To: patched->closed

Committed. Thanks!