Bug 116266

Summary: [Maintainer Update] games/crafty: fixes & features
Product: Ports & Packages Reporter: shoemaker <shoemaker>
Component: Individual Port(s)Assignee: freebsd-ports-bugs (Nobody) <ports-bugs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
file.diff
none
file.diff none

Description shoemaker 2007-09-10 22:30:01 UTC 
	Does not need to ber setuid nobody, as this breaks the
per-user rc-files goal; setgid with group-writable files should
suffice.  Configured for the new personalities feature, and added a
fix to make sure that help is available (wasn't working before as it
was moved from the executable to a file.)

Fix: 

----------------------------------------------------------------------
Find out how you can get spam free email.
http://www.bluebottle.com/tag/3--8JISsEZsBYodXcBBMM42IyeurEnUALiM2QiQ6H0muWrnKnNz
Content-Type: text/plain; name="file.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment; filename="file.diff"

--- crafty/Makefile.orig	Sun Sep  9 19:11:53 2007
+++ crafty/Makefile	Mon Sep 10 15:08:53 2007
@@ -41,12 +41,15 @@
 .if !defined(WITH_TBDIR)
 WITH_TBDIR=	${PREFIX}/lib/crafty/TB
 .endif
-
+.if !defined(WITH_PERSDIR)
+WITH_PERSDIR=	${PREFIX}/lib/crafty/cpf
+.endif
 OPT=		-DHASHSTATS -DTRACE -DBOOKDIR=\\\"${WITH_BOOKDIR}\\\" \
 		-DLOGDIR=\\\"${WITH_LOGDIR}\\\" \
 	       	-DRCDIR=\\\"${WITH_RCDIR}\\\" \
-		-DTBDIR=\\\"${WITH_TBDIR}\\\"
-
+		-DTBDIR=\\\"${WITH_TBDIR}\\\" \
+		-DPERSDIR=\\\"${WITH_PERSDIR}\\\"
+ 
 .include <bsd.port.pre.mk>
 
 .if ${ARCH} == "i386"
@@ -71,17 +74,18 @@
 
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/crafty ${PREFIX}/bin/crafty
-	${CHOWN} nobody:nogroup ${PREFIX}/bin/crafty
-	${CHMOD} 6555 ${PREFIX}/bin/crafty
-	${MKDIR} ${PREFIX}/lib/crafty
-	${CHOWN} nobody:nogroup ${PREFIX}/lib/crafty
+	${CHOWN} root:nogroup ${PREFIX}/bin/crafty
+	${CHMOD} 2555 ${PREFIX}/bin/crafty
+	${MKDIR} ${PREFIX}/lib/crafty/cpf
+	${CHOWN} -R root:nogroup ${PREFIX}/lib/crafty
+	${CHMOD} 775 ${PREFIX}/lib/crafty ${PREFIX}/lib/crafty/cpf
 	${INSTALL_DATA} ${WRKSRC}/books.bin ${PREFIX}/lib/crafty/books.bin
 	${INSTALL_DATA} ${WRKSRC}/book.lrn ${PREFIX}/lib/crafty/book.lrn
 	${INSTALL_DATA} ${WRKSRC}/position.bin ${PREFIX}/lib/crafty/position.bin
 	${INSTALL_DATA} ${WRKSRC}/position.lrn ${PREFIX}/lib/crafty/position.lrn
 	${TOUCH} ${PREFIX}/lib/crafty/book.bin
-	${CHOWN} nobody:nogroup ${PREFIX}/lib/crafty/book*
-	${CHOWN} nobody:nogroup ${PREFIX}/lib/crafty/position*
+	${CHOWN} root:nogroup ${PREFIX}/lib/crafty/book*
+	${CHOWN} root:nogroup ${PREFIX}/lib/crafty/position*
 	${CHMOD} 664 ${PREFIX}/lib/crafty/book*
 	${CHMOD} 664 ${PREFIX}/lib/crafty/position*
 .if !defined(NOPORTDOCS)
Comment 1 shoemaker 2007-09-10 22:34:16 UTC 
Please add the following patch as well, after the first, to tie up a
loose end...

--- Makefile.orig	Mon Sep 10 15:29:56 2007
+++ Makefile	Mon Sep 10 15:29:12 2007
@@ -83,6 +83,7 @@
 	${INSTALL_DATA} ${WRKSRC}/book.lrn ${PREFIX}/lib/crafty/book.lrn
 	${INSTALL_DATA} ${WRKSRC}/position.bin ${PREFIX}/lib/crafty/position.bin
 	${INSTALL_DATA} ${WRKSRC}/position.lrn ${PREFIX}/lib/crafty/position.lrn
+	${INSTALL_DATA} ${WRKSRC}/crafty.hlp ${PREFIX}/lib/crafty/crafty.hlp
 	${TOUCH} ${PREFIX}/lib/crafty/book.bin
 	${CHOWN} root:nogroup ${PREFIX}/lib/crafty/book*
 	${CHOWN} root:nogroup ${PREFIX}/lib/crafty/position*

----------------------------------------------------------------------
Get a free email address with REAL anti-spam protection.
http://www.bluebottle.com/tag/1
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-09-11 13:00:48 UTC 
edwin       2007-09-11 12:00:42 UTC

  FreeBSD ports repository

  Modified files:
    games/crafty         Makefile pkg-plist 
    games/crafty/scripts configure 
  Added files:
    games/crafty/files   patch-option.c 
  Log:
  [Maintainer Update] games/crafty: fixes & features
  
          Does not need to ber setuid nobody, as this breaks the
          per-user rc-files goal; setgid with group-writable files should
          suffice. Configured for the new personalities feature, and added a
          fix to make sure that help is available (wasn't working before as it
          was moved from the executable to a file.)
  
  PR:             ports/116266
  Submitted by:   shoemaker@bluebottle.com (Jonathan Shoemaker)
  
  Revision  Changes    Path
  1.34      +14 -9     ports/games/crafty/Makefile
  1.1       +15 -0     ports/games/crafty/files/patch-option.c (new)
  1.7       +2 -0      ports/games/crafty/pkg-plist
  1.2       +3 -2      ports/games/crafty/scripts/configure
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2007-09-11 13:01:29 UTC 
State Changed
From-To: open->closed

Committed, thanks!