Bug 116286

Summary: [PATCH] sysutils/e2fsprogs: clean-up
Product: Ports & Packages Reporter: Alejandro Pulver <alepulver>
Component: Individual Port(s)Assignee: Alejandro Pulver <alepulver>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
e2fsprogs.diff none

Description Alejandro Pulver freebsd_committer freebsd_triage 2007-09-11 19:20:06 UTC 

- Bump PORTREVISION.
- Add OPTIONS for NLS instead of using knob.
- Format the Makefile and pkg-message.
- Avoid installing of some files instead of deleting them after.
- Remove pkg-install, do the link/copy automatically.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-09-11 19:20:14 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

Submitter has GNATS access
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2007-09-11 19:20:21 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback
Comment 3 Matthias Andree 2007-09-18 09:19:44 UTC 
Hi Alejandro,

please do not mix formatting changes with functional changes in the same
patch, that makes it hard to read.

I object to some parts:

1. apparently the pkg-install->pkg-plist revision now expects or
installs e2fsck into /usr/sbin, where it used to be in /sbin before.
This can break existing setups that call fsck from /etc/fstab if /usr
isn't mounted soon enough.

2. there are lots of unnecessary "quiet" options (leading @ in rules) in
the Makefile that I cannot accept.

Please close this PR, I'll supersede ports/116230 with a merged version
of this PR (ports/116286) and ports/116230.

Sorry for not taking your patch directly.

Best regards
Matthias
Comment 4 Matthias Andree 2007-09-18 09:23:21 UTC 
Oh, there's one more point:

the "direct inclusion" leads to package bloat, because then the somewhat
largish e2fsck is included twice.  We might consider @exec however but I
don't see much of a difference to pkg-install then.

Best
Matthias
Comment 5 Matthias Andree 2007-09-18 11:55:48 UTC 
Please close this one and use ports/116434 instead. Thanks.
Comment 6 Alejandro Pulver freebsd_committer freebsd_triage 2007-09-28 00:56:50 UTC 
State Changed
From-To: feedback->closed

Obsoleted by 116434.