Bug 116680
| Summary: | [patch] fwohci(4): Documentation mistake: CXD1947 _not_ supported, see fwohci_pci.c | ||
|---|---|---|---|
| Product: | Documentation | Reporter: | Jens Köhler <mail> |
| Component: | Books & Articles | Assignee: | Christian Brueffer <brueffer> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
State Changed From-To: open->feedback So where is the part of the documentation that has the bug, so we can address it? State Changed From-To: feedback->analyzed OK, after some investigation I've figured out where the manpage lives. OTOH I don't have any manpage-fu so all I can do is generate the patch (which seems obvious). Is anyone from docs interested in testing and comitting? cvs diff: Diffing . Index: fwohci.4 =================================================================== RCS file: /home/FreeBSD/ncvs/src/share/man/man4/fwohci.4,v retrieving revision 1.16 diff -r1.16 fwohci.4 102,103d101 < Sony i.LINK (CXD1947) < .It Responsible Changed From-To: freebsd-bugs->freebsd-doc brueffer 2008-03-03 08:55:50 UTC
FreeBSD src repository
Modified files:
share/man/man4 fwohci.4
Log:
The Sony i.LINK (CXD1947) is _not_ supported.
PR: 116680
Submitted by: Jens Köhler <mail@chatty.de>
MFC after: 3 days
Revision Changes Path
1.17 +1 -3 src/share/man/man4/fwohci.4
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: analyzed->patched Fixed in CURRENT, MFC pending. Thanks! Responsible Changed From-To: freebsd-doc->brueffer MFC reminder. State Changed From-To: patched->closed This doc bug is fixed in HEAD, RELENG_7 and RELENG_6. |
FreeBSD probably NEVER supported CXD1947! What a pity. See your own patch: ==== //depot/projects/smpng/sys/dev/firewire/fwohci_pci.c#35 (text+ko) ==== @@ -31,7 +31,7 @@ * ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE * POSSIBILITY OF SUCH DAMAGE. * - * $FreeBSD: src/sys/dev/firewire/fwohci_pci.c,v 1.52 2005/05/20 12:37:16 marius Exp $ + * $FreeBSD: src/sys/dev/firewire/fwohci_pci.c,v 1.53 2005/07/17 19:59:07 imp Exp $ */ #define BOUNCE_BUFFER_TEST 0 @@ -169,8 +169,8 @@ return BUS_PROBE_DEFAULT; } if (id == (FW_VENDORID_SONY | FW_DEVICE_CXD1947)) { - device_set_desc(dev, "Sony i.LINK (CXD1947)"); - return BUS_PROBE_DEFAULT; + device_printf(dev, "Sony i.LINK (CXD1947) not supported"); + return ENXIO; } if (id == (FW_VENDORID_SONY | FW_DEVICE_CXD3222)) { device_set_desc(dev, "Sony i.LINK (CXD3222)"); Fix: write some cool driver How-To-Repeat: install on adequate hardware