Bug 117160

Summary: maintainer update] net/freeradius; variuos small fixes
Product: Ports & Packages Reporter: David Wood <david>
Component: Individual Port(s)Assignee: Li-Wen Hsu <lwhsu>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description David Wood 2007-10-13 23:10:01 UTC
- Remove more 4.x cruft (obsolete comment in Makefile, obsolete patch,
  simplification in WITH_NOPERL handling in Makefile).
- Use MASTER_SITE_SUBDIR rather than an explicit /old reference in
  MASTER_SITES.
- Tidy pkg-plist, including the use of @stopdaemon and some mild reordering
  so that it is more logical.
- Avoid spurious -L/usr/lib in the radiusd build step when using base OpenSSL.
- Use ${PTHREAD_LIBS} rather than -pthread.
- Remove the -p flag to cp when copying files into /usr/local/etc/raddb (this
  may help stop FreeRADIUS stomping over explicitly set ownership and
  permissions in this directory). [1]
- Generalise CONFLICTS.
- Support WITH_DEVELOPER (though it has to be used as a knob - I see no reason
  to add this to the OPTIONS).
- Bump PORTREVISION.

[1] May address a concern of sem@ (discussion by private mail)


Whilst it was hoped that the -L/usr/lib change would help with the problems on
7.x amd64 (which is, unfortunately, not as simple as a lack of -fPIC), and
indeed the tendency to generate a broken radiusd binary with gcc 4.2 on other
platforms, this now looks to be a libtool problem which I will bring up on
freebsd-ports and/or in a separate PR. However, the port should do the right
thing anyway, and I wanted to tidy up these issues before asking for help.

These updates are also a precursor to submitting net/freeradius-devel for
FreeRADIUS 2.0.0-pre2, which will be submitted as a patch from the port as it
stands after these changes in a separate PR.


Note: files/patch-src-modules-rlm_attr_rewrite-rlm_attr_rewrite.c has been
removed.

Fix: Patch attached with submission follows:
Comment 1 Li-Wen Hsu freebsd_committer freebsd_triage 2007-10-14 02:56:24 UTC
Responsible Changed
From-To: freebsd-ports-bugs->lwhsu

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-10-28 22:08:52 UTC
lwhsu       2007-10-28 22:08:45 UTC

  FreeBSD ports repository

  Modified files:
    net/freeradius       Makefile pkg-plist 
  Removed files:
    net/freeradius/files 
                         patch-src-modules-rlm_attr_rewrite-rlm_attr_rewrite.c 
  Log:
  - Remove more 4.x cruft (obsolete comment in Makefile, obsolete patch,
    simplification in WITH_NOPERL handling in Makefile).
  - Use MASTER_SITE_SUBDIR rather than an explicit /old reference in
    MASTER_SITES.
  - Tidy pkg-plist, including the use of @stopdaemon and some mild reordering
    so that it is more logical.
  - Avoid spurious -L/usr/lib in the radiusd build step when using base OpenSSL.
  - Use ${PTHREAD_LIBS} rather than -pthread.
  - Remove the -p flag to cp when copying files into /usr/local/etc/raddb (this
    may help stop FreeRADIUS stomping over explicitly set ownership and
    permissions in this directory). [1]
  - Generalise CONFLICTS.
  - Support WITH_DEVELOPER (though it has to be used as a knob - I see no reason
    to add this to the OPTIONS).
  - Bump PORTREVISION.
  
  [1] May address a concern of sem@ (maintainer had discussion by private mail)
  
  PR:             ports/117160
  Submitted by:   David Wood <david AT wood2.org.uk> (maintainer)
  
  Revision  Changes    Path
  1.62      +18 -11    ports/net/freeradius/Makefile
  1.2       +0 -10     ports/net/freeradius/files/patch-src-modules-rlm_attr_rewrite-rlm_attr_rewrite.c (dead)
  1.32      +11 -12    ports/net/freeradius/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Li-Wen Hsu freebsd_committer freebsd_triage 2007-10-28 22:17:07 UTC
State Changed
From-To: open->closed

Committed. Thanks!