Bug 117803

Summary: Fix net-mgmt/kismet for FreeBSD 7.0
Product: Ports & Packages Reporter: onatan
Component: Individual Port(s)Assignee: Tom McLaughlin <tmclaugh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-pcapsource.cc
none
kismet-freebsd7.diff none

Description onatan 2007-11-04 06:40:00 UTC 
Kismet redefines some thins that are already there.
It also doesn't include bpf when it should.

How-To-Repeat: Try building the port, see it break.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-11-04 06:40:10 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Peter Thoenen 2007-11-04 12:55:02 UTC 
Hmm ... can somebody else verify that the pre-patch kismet doesn't build 
on 7.0.  On my box (7.0-BETA2) it builds just fine w/o this patch.

-Peter
Comment 3 Tom McLaughlin 2007-11-05 18:29:31 UTC 
Hi, here are the compile warnings as they stands right now on FreeBSD
7.x.  (Submitter, please send error/warning output next time so the
maintainer can see exactly where the problem is and so they aren't left
with blindly patching the port.)

pcapsource.cc:840:1: warning: "IEEE80211_IS_CHAN_FHSS" redefined
In file included from /usr/include/net80211/ieee80211_ioctl.h:34,
                 from pcapsource.cc:79:
/usr/include/net80211/_ieee80211.h:175:1: warning: this is the location of the previous definition
pcapsource.cc:842:1: warning: "IEEE80211_IS_CHAN_A" redefined
/usr/include/net80211/_ieee80211.h:177:1: warning: this is the location of the previous definition
pcapsource.cc:844:1: warning: "IEEE80211_IS_CHAN_B" redefined
/usr/include/net80211/_ieee80211.h:179:1: warning: this is the location of the previous definition
pcapsource.cc:846:1: warning: "IEEE80211_IS_CHAN_PUREG" redefined
/usr/include/net80211/_ieee80211.h:181:1: warning: this is the location of the previous definition
pcapsource.cc:848:1: warning: "IEEE80211_IS_CHAN_G" redefined
/usr/include/net80211/_ieee80211.h:183:1: warning: this is the location of the previous definition

Attached is a smaller patch which only renames the conflicting macros.
Can you also point out where we can see the issue with bpf?  I don't
have a wifi nic in my -CURRENT box to run test kismet.

-- 
| tmclaugh at sdf.lonestar.org                 tmclaugh at FreeBSD.org |
| FreeBSD                                       http://www.FreeBSD.org |
Comment 4 Tom McLaughlin freebsd_committer freebsd_triage 2007-11-05 18:31:52 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->tmclaugh

Grab PR
Comment 5 Tom McLaughlin freebsd_committer freebsd_triage 2007-11-05 21:20:28 UTC 
State Changed
From-To: feedback->closed

Received OK from maintainer to close this PR with no commits.  The bpf 
issue was due to an issue in src/ which has been resolved.  The 
definition renaming is unnecessary as well.  The warnings do not cause a 
crash to occur and changes to clean up the code should be pursued 
upstream.