Bug 118139
| Summary: | [PATCH] port mail/qmail-scanner: Makefile: QS_NOTIFY not correctly passed to configure | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Rainer Schwarze <rsc> | ||||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | ||||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Edwin Groothuis escreveu: > Maintainer of mail/qmail-scanner, > > Please note that PR ports/118139 has just been submitted. > > If it contains a patch for an upgrade, an enhancement or a bug fix > you agree on, reply to this email stating that you approve the patch > and a committer will take care of it. > > The full text of the PR can be found at: > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/118139 > Hello Edwin, Yes, I agree that with minor changes, follow as attach, thanks! -- Atenciosamente, Felippe de Meirelles Motta FreeBSD Brasil LTDA. http://www.freebsdbrasil.com.br State Changed From-To: feedback->open Maintainer has supplied a patch in the followup. State Changed From-To: open->closed Patch from maintainer committed. pav 2007-12-15 22:26:01 UTC
FreeBSD ports repository
Modified files:
mail/qmail-scanner Makefile
Log:
- Properly pass QS_USER, QS_ADMIN and QS_NOTIFY values to configure script
PR: ports/118139
Submitted by: Rainer Schwarze <rsc@admadic.de>,
Felippe de Meirelles Motta <lippe@freebsdbrasil.com.br> (maintainer) (patch used)
Revision Changes Path
1.19 +5 -3 ports/mail/qmail-scanner/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
In port mail/qmail-scanner the Makefile does not correctly append the QS_NOTIFY value to CONFIGURE_ARGS when QS_NOTIFY has been specified with the make call. When QS_NOTIFY is not specified, the Makefile defaults will be used, when it is specified, the Makefile does not append "--notify ..." to CONFIGURE_ARGS and the defaults of the configure script are used. For instance, if the notifications should only be sent to the admin ( make QS_NOTIFY=admin ), the result of the build process is as if configure was called with "--notify psender,precips" instead of "--notify admin". Fix: (See patch file) After these lines in Makefile: .if !defined(QS_NOTIFY) CONFIGURE_ARGS+= --notify psender,precips .endif add these lines: .if defined(QS_NOTIFY) CONFIGURE_ARGS+= --notify "${QS_NOTIFY}" .endif Patch attached with submission follows: How-To-Repeat: Run "make QS_NOTIFY=admin". Run "grep NOTIFY_ADDRS work/qmail-scanner-2.01/qmail-scanner-queue.pl" - the first line will read "my $NOTIFY_ADDRS='psender,nmlvadm'". It should be "my $NOTIFY_ADDRS='admin'"