Bug 118202

Summary: [patch] wxgtk26 + gtk20 incompatibility crashes audio/audacity
Product: Ports & Packages Reporter: Henrik Gulbrandsen <henrik>
Component: Individual Port(s)Assignee: Max Khon <fjoe>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.shar none

Description Henrik Gulbrandsen 2007-11-22 16:40:01 UTC 
The audio/audacity port segfaults in 7.0-BETA3. If the $HOME/.audacity file is
missing, this happens immediately at startup. It turns out that the wxWidgets
port (x11-toolkits/wxgtk26) is incompatible with a recent upgrade of the GTK+
port (x11-toolkits/gtk20) from 2.10.14 to 2.12.1, since GtkBorder objects can
no longer be released with g_free(). Attempting to do so anyway will instead
release a large block of internal data structures needed for memory allocation
in GLib, leading to extensive memory corruption and premature death.

Note that many programs using the wxgtk26 port are likely to be affected by this
bug in more or less subtle ways. The required patches are already included in
wx-2.8.x and are not needed for wx-2.4.x, so this is specific to wxgtk26.

Fix: The attached shell archive contains two single-line patches suitable for the
x11-toolkits/wxgtk26/files directory. With a lack of bad luck, that's it!


Patch attached with submission follows:
How-To-Repeat: Memory corruption problems can be tricky to reproduce, but I would try removing
any pre-existing $HOME/.audacity file before starting audacity. The bug may also
depend on the actual GTK theme in use, so you might need some variation there.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-11-22 22:52:04 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Max Khon freebsd_committer freebsd_triage 2007-11-24 07:03:02 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->fjoe

Mine.
Comment 3 Max Khon freebsd_committer freebsd_triage 2007-11-24 19:56:53 UTC 
State Changed
From-To: feedback->closed

Committed. Thank you for high quality problem report!
Comment 4 dfilter service freebsd_committer freebsd_triage 2007-11-24 20:00:13 UTC 
fjoe        2007-11-24 19:58:44 UTC

  FreeBSD ports repository

  Modified files:
    x11-toolkits/wxgtk26 Makefile 
    x11-toolkits/wxgtk26-unicode Makefile 
  Added files:
    x11-toolkits/wxgtk26/files patch-src-gtk-button.cpp 
                               patch-src-gtk-window.cpp 
  Log:
  Fix coredump: use gtk_border_free() insead of g_free()
  for freeing border objects. The change exists in wxgtk 2.8 and later.
  
  PR:             118202
  Submitted by:   Henrik Gulbrandsen
  Approved by:    portmgr (linimon)
  
  Revision  Changes    Path
  1.12      +1 -1      ports/x11-toolkits/wxgtk26-unicode/Makefile
  1.38      +1 -1      ports/x11-toolkits/wxgtk26/Makefile
  1.1       +11 -0     ports/x11-toolkits/wxgtk26/files/patch-src-gtk-button.cpp (new)
  1.1       +11 -0     ports/x11-toolkits/wxgtk26/files/patch-src-gtk-window.cpp (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"