Bug 118425

Summary: [maintainer update] net/freeradius - fix build on 7.x amd64 and 6.x with gcc 4.2, also various other fixes
Product: Ports & Packages Reporter: David Wood <david>
Component: Individual Port(s)Assignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description David Wood 2007-12-04 15:30:01 UTC 
- Patch src/main/Makefile to remove -pie for radiusd. [1]
  This produces a runnable radiusd on:
  * 6.2-RELEASE-p9 i386 with USE_GCC=4.2 and up to date lang/gcc42
  * RELENG_7 i386 from a couple of days ago
  * RELENG_7 amd64 (according to the report I received)
  which were previously broken, and is a no-op on:
  * 6.2-RELEASE-p9 i386
  * RELENG_6_3 i386 from a couple of days ago.
- Chase heimdal shared version library bump (which was missed somehow). [2]
- Remove files/patch-src-modules-rlm_attr_rewrite-rlm_attr_rewrite.c. This is
  4.x cruft which should have been removed as parts of ports/117160 but got
  missed.
- Rework files/radiusd.sh.in, not least to address the bug reported in
  ports/117262
- Bump PORTREVISION.

[1] Reported by: Sean McNeil <sean@mcneil.com>
[2] Reported by: Gioto Alves Lourenco <gioto@pop-ro.rnp.br>

Note: this affects the patch in ports/117161, which will not now apply
cleanly. The solution is to update files/patch-radiusd-no-pie for the 2.x
version of src/main/Makefile (the same change is needed as in 1.x).


******************************************************************************
PORTS FREEZE COMMENTS
******************************************************************************
- Item 1 fixes a build failure on RELENG_7 amd64.
- Item 2 fixes a build failure on all platforms (though not with
  default options).

I believe that at least these two items may qualify for committing during the
current ports freeze (portmgr@ alerted).


If the deletion of 
files/patch-src-modules-rlm_attr_rewrite-rlm_attr_rewrite.c
and the changes to
files/radiusd.sh.in
do not qualify for committing during ports freeze, ignore the patches to those
files, and I'll PR them separately. The other changes can stand alone (patch
to Makefile and new file files/patch-radiusd-no-pie).


******************************************************************************
FILES TO BE ADDED
******************************************************************************
files/patch-radiusd-no-pie

******************************************************************************
FILES TO BE REMOVED
******************************************************************************
files/patch-src-modules-rlm_attr_rewrite-rlm_attr_rewrite.c

Fix: Apply the attached patch.

Patch attached with submission follows:
Comment 1 Marcelo Araujo freebsd_committer freebsd_triage 2007-12-05 10:17:25 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->araujo

I'll take it.
Comment 2 dfilter service freebsd_committer freebsd_triage 2007-12-06 10:01:07 UTC 
araujo      2007-12-06 10:01:03 UTC

  FreeBSD ports repository

  Modified files:
    net/freeradius       Makefile 
    net/freeradius/files radiusd.sh.in 
  Added files:
    net/freeradius/files patch-radiusd-no-pie 
  Log:
  - Added patch to remove -pie for radiusd. [1]
  - Fixed a build failure on RELENG_7 AMD64.
  - Chase heimdal shared version library bump. [2]
  - Reworked RC script. [3]
  - Mark as unbroken on AMD64.
  - Bump PORTREVISION.
  
  PR:             ports/118425, ports/117262 [3]
  Reported by:    Sean McNeil <sean@mcneil.com> [1], Gioto Alves Lourenco <gioto@pop-ro.rnp.br> [2]
  Submitted by:   Craig Leres <leres@ee.lbl.gov> [3], David Wood <david@wood2.org.uk> (maintainer)
  Approved by:    portmgr (marcus), stas (mentor, implicit)
  
  Revision  Changes    Path
  1.63      +6 -12     ports/net/freeradius/Makefile
  1.1       +11 -0     ports/net/freeradius/files/patch-radiusd-no-pie (new)
  1.3       +9 -3      ports/net/freeradius/files/radiusd.sh.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Marcelo Araujo freebsd_committer freebsd_triage 2007-12-06 10:23:38 UTC 
State Changed
From-To: open->closed

Committed, with minor changes. Thanks!