Bug 118758

Summary: [PATCH] sysutils/fusefs-kmod: bug fixes from Hg repo, data corruption workaround
Product: Ports & Packages Reporter: Alejandro Pulver <alepulver>
Component: Individual Port(s)Assignee: Alejandro Pulver <alepulver>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
fusefs-kmod.diff none

Description Alejandro Pulver freebsd_committer freebsd_triage 2007-12-17 03:50:00 UTC

- Bump PORTREVISION.
- Add checks in rc.d scripts to avoid "double" loading/unloading.
- Add patch-fuse_io.c (fix from http://mercurial.creo.hu/repos/fuse4bsd-hg/?rev/d7bf90a8cc85).
- Handle "nonempty" option by ignoring it, used by ntfs-3g (http://mercurial.creo.hu/repos/fuse4bsd-hg/?rev/aef999f12049).
- In the rc.d script unmount FUSE filesystem in the "stop" command, in reverse order in case the mounts are nested, waiting one second after each. This is a temporary workaround for umount returning before the cache has been flushed (which causes for example files not being written to the disk), a proper solution is being worked on.
- Add note in pkg-message about "stop" rc.d command unmounting FUSE filesystems.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2007-12-17 03:50:07 UTC
Responsible Changed
From-To: freebsd-ports-bugs->alepulver

Submitter has GNATS access (via the GNATS Auto Assign Tool)
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2007-12-17 03:50:12 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 amistry 2007-12-17 05:28:10 UTC
Looks good.  I'm assuming this is the result of the discussion 
on -hackers?

-- 
Anish Mistry
amistry@am-productions.biz
AM Productions http://am-productions.biz/
Comment 4 Alejandro Pulver freebsd_committer freebsd_triage 2007-12-17 16:32:45 UTC
On Mon, 17 Dec 2007 05:30:04 GMT
Anish Mistry <amistry@am-productions.biz> wrote:

>  Looks good.  I'm assuming this is the result of the discussion
>  on -hackers?
>  


Partially. The result will be worked out by the fuse4bsd author (it
seems he will start soon). This is just a workaround that should help
in most cases (I personally never had problems with it, but did have
before having it).

"Looks good" means you approve it?

Best Regards,
Ale
Comment 5 amistry 2007-12-17 16:54:03 UTC
On Monday 17 December 2007, Alejandro Pulver wrote:
> On Mon, 17 Dec 2007 05:30:04 GMT
>
> Anish Mistry <amistry@am-productions.biz> wrote:
> >  Looks good.  I'm assuming this is the result of the discussion
> >  on -hackers?
>
> Partially. The result will be worked out by the fuse4bsd author (it
> seems he will start soon). This is just a workaround that should
> help in most cases (I personally never had problems with it, but
> did have before having it).
>
> "Looks good" means you approve it?

Yes.  Commit.


-- 
Anish Mistry
amistry@am-productions.biz
AM Productions http://am-productions.biz/
Comment 6 dfilter service freebsd_committer freebsd_triage 2007-12-17 17:22:14 UTC
alepulver    2007-12-17 17:22:09 UTC

  FreeBSD ports repository

  Modified files:
    sysutils/fusefs-kmod Makefile 
    sysutils/fusefs-kmod/files fusefs.in 
                               patch-mount_fusefs-mount_fusefs.c 
                               pkg-message.in 
  Added files:
    sysutils/fusefs-kmod/files patch-fuse_io.c 
  Log:
  - Bump PORTREVISION.
  - Add checks in rc.d scripts to avoid "double" loading/unloading.
  - Add patch-fuse_io.c (fix from
    http://mercurial.creo.hu/repos/fuse4bsd-hg/?rev/d7bf90a8cc85).
  - Handle "nonempty" option by ignoring it, used by ntfs-3g
    (http://mercurial.creo.hu/repos/fuse4bsd-hg/?rev/aef999f12049).
  - In the rc.d script unmount FUSE filesystem in the "stop" command, in reverse
    order in case the mounts are nested, waiting one second after each. This is
    a temporary workaround for umount returning before the cache has been
    flushed (which causes for example files not being written to the disk), a
    proper solution is being worked on.
  - Add note in pkg-message about "stop" rc.d command unmounting FUSE
    filesystems.
  
  PR:             ports/118758
  Submitted by:   alepulver (myself)
  Approved by:    Anish Mistry <amistry@am-productions.biz> (maintainer)
  
  Revision  Changes    Path
  1.17      +1 -1      ports/sysutils/fusefs-kmod/Makefile
  1.5       +19 -1     ports/sysutils/fusefs-kmod/files/fusefs.in
  1.1       +11 -0     ports/sysutils/fusefs-kmod/files/patch-fuse_io.c (new)
  1.2       +13 -3     ports/sysutils/fusefs-kmod/files/patch-mount_fusefs-mount_fusefs.c
  1.2       +5 -0      ports/sysutils/fusefs-kmod/files/pkg-message.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Alejandro Pulver freebsd_committer freebsd_triage 2007-12-17 17:22:36 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!