Bug 119758

Summary: [UPDATE] x11-fm/gprename
Product: Ports & Packages Reporter: Felippe de Meirelles Motta <lippemail>
Component: Individual Port(s)Assignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
gprename.diff none

Description Felippe de Meirelles Motta 2008-01-17 20:50:01 UTC 
- Updated to 2.5 version;
- Use SF macro;
- Now install all requirements: Glib Perl, Perl Gettext, Libintl Perl and Gtk2 Perl;
- Updated pkg-plist;
- Some minor changes in Makefile that were unnecessary.

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-01-17 20:50:05 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 2 Martin Tournoij 2008-01-17 22:10:04 UTC 
Thank you for the PR Felippe.
A new patch is attached in this email:

- Replacing /usr/local with PREFIX is needed for people who have a
	different prefix.

- CURDIR works for GNU make, but BSD make uses .CURDIR and doesn't
	know about CURDIR (Your default make is GNU make..?).

- p5-Locale-gettext isn't needed, and p5-Glib is already a dependency
	(Through Gtk2, and probably others).

- PREFIX/bin/perl should be used whenever possible, /usr/bin/perl is a
	leftover from when perl was included in FreeBSD base and it will
	probably be removed at some point in the future.

Regards,
Martin Tournoij
Comment 3 Marcelo Araujo freebsd_committer freebsd_triage 2008-01-18 00:12:50 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->araujo

I'll take it.
Comment 4 araujobsdport 2008-01-20 01:07:56 UTC 
Hey all,

What you think in using WITH_NLS to control the internationalization files?
Could you please think about that?

Thanks about the work!



Best Regards,

-- 
Marcelo Araujo            (__)
araujo@FreeBSD.org     \\\'',)
http://www.FreeBSD.org   \/  \ ^
Power To Server.         .\. /_)
Comment 5 Felippe de Meirelles Motta 2008-01-24 21:51:29 UTC 
Hello araujo@,

I see that this software use Makefile only for install all files, not 
use an configure with make options to disable any feature.

My cheers! :)
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-01-26 13:26:19 UTC 
araujo      2008-01-26 13:26:15 UTC

  FreeBSD ports repository

  Modified files:
    x11-fm/gprename      Makefile distinfo pkg-plist 
  Log:
  - Update to 2.5.
  - Use SF macro.
  
  PR:             ports/119758
  Submitted by:   Felippe de Meirelles Motta <lippemail@gmail.com>
  Reworked by:    Martin Tournoij <carpetsmoker@xs4all.nl> (maintainer)
  Approved by:    stas (mentor, implicit)
  
  Revision  Changes    Path
  1.14      +5 -6      ports/x11-fm/gprename/Makefile
  1.10      +3 -3      ports/x11-fm/gprename/distinfo
  1.3       +1 -0      ports/x11-fm/gprename/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Marcelo Araujo freebsd_committer freebsd_triage 2008-01-26 13:26:42 UTC 
State Changed
From-To: feedback->closed

Committed, with minor changes. Thanks!