Bug 120192

Summary: Current gvinum(8) is not usable
Product: Base System Reporter: Nicolae Namolovan <adrenalinup>
Component: kernAssignee: Ulf Lilleengen <lulf>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description Nicolae Namolovan 2008-01-31 21:20:01 UTC
Current gvinum is not usable, yesterday I got a kernel panic.

http://lists.freebsd.org/pipermail/freebsd-geom/2007-November/002683.html
I saw the same problem on the mail list, yet not fixed..

I heard there is some patches from Google Sumer Code ? Anyway, I can't
manage to compile them, this is what I get..

http://people.freebsd.org/~lulf/patches/gvinum/gvinum_2007-11-03_RELENG_7.diff

===> geom_vinum (all)
cc -O2 -march=nocona -fno-strict-aliasing  -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c: In function 'gv_init':
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c:177: warning: implicit declaration of function 'kproc_create'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c:177: warning: nested extern declaration of 'kproc_create'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c: In function 'gv_worker':
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c:931: warning: implicit declaration of function 'kproc_exit'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c:931: warning: nested extern declaration of 'kproc_exit'
cc -O2 -march=nocona -fno-strict-aliasing  -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:657: error: redefinition of 'gv_create_drive'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:46: error: previous definition of 'gv_create_drive' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:788: error: redefinition of 'gv_create_volume'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:177: error: previous definition of 'gv_create_volume' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:802: error: redefinition of 'gv_create_plex'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:191: error: previous definition of 'gv_create_plex' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:837: error: redefinition of 'gv_create_sd'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:226: error: previous definition of 'gv_create_sd' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:923: error: redefinition of 'gv_concat'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:312: error: previous definition of 'gv_concat' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:989: error: redefinition of 'gv_mirror'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:378: error: previous definition of 'gv_mirror' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1078: error: redefinition of 'gv_raid5'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:467: error: previous definition of 'gv_raid5' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1157: error: redefinition of 'gv_stripe'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:546: error: previous definition of 'gv_stripe' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1268: error: redefinition of 'gv_create_drive'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:46: error: previous definition of 'gv_create_drive' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1399: error: redefinition of 'gv_create_volume'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:177: error: previous definition of 'gv_create_volume' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1413: error: redefinition of 'gv_create_plex'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:191: error: previous definition of 'gv_create_plex' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1448: error: redefinition of 'gv_create_sd'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:226: error: previous definition of 'gv_create_sd' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1534: error: redefinition of 'gv_concat'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:312: error: previous definition of 'gv_concat' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1600: error: redefinition of 'gv_mirror'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:378: error: previous definition of 'gv_mirror' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1689: error: redefinition of 'gv_raid5'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:467: error: previous definition of 'gv_raid5' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1768: error: redefinition of 'gv_stripe'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:546: error: previous definition of 'gv_stripe' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:1879: error: redefinition of 'gv_create_drive'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:46: error: previous definition of 'gv_create_drive' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2010: error: redefinition of 'gv_create_volume'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:177: error: previous definition of 'gv_create_volume' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2024: error: redefinition of 'gv_create_plex'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:191: error: previous definition of 'gv_create_plex' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2059: error: redefinition of 'gv_create_sd'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:226: error: previous definition of 'gv_create_sd' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2145: error: redefinition of 'gv_concat'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:312: error: previous definition of 'gv_concat' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2211: error: redefinition of 'gv_mirror'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:378: error: previous definition of 'gv_mirror' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2300: error: redefinition of 'gv_raid5'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:467: error: previous definition of 'gv_raid5' was here
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:2379: error: redefinition of 'gv_stripe'
/usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum_create.c:546: error: previous definition of 'gv_stripe' was here
*** Error code 1

Stop in /usr/src/sys/modules/geom/geom_vinum.
*** Error code 1

Stop in /usr/src/sys/modules/geom.


Thanks for your assistance.. I'll try ZFS in the mean time..

Fix: 

http://lists.freebsd.org/pipermail/freebsd-geom/2007-November/002683.html
How-To-Repeat: http://lists.freebsd.org/pipermail/freebsd-geom/2007-November/002683.html
Comment 1 Volker 2008-02-01 13:16:12 UTC
Nicolae,

I'm assuming you're trying to compile that patch, downloaded from
~lulf - am I wrong?

If so, please ask the maintainer whether or not these patches are
still valid and ask for help. Unfortunately we're unable to handle PRs
for code not in CVS. We're sorry about that.

If you're getting a kernel panic with code compiled from CVS, please
post the panic message and a backtrace. Please provide as much
information as possible to have someone else investigate that problem.

Thanks!

Volker
Comment 2 Ulf Lilleengen freebsd_committer freebsd_triage 2008-02-11 17:35:04 UTC
Responsible Changed
From-To: freebsd-bugs->lulf

- Investigating
Comment 3 Ulf Lilleengen 2008-02-11 17:38:15 UTC
On tor, jan 31, 2008 at 09:14:35pm +0000, Nicolae Namolovan wrote:
> 
> >Number:         120192
> >Category:       kern
> >Synopsis:       Current gvinum is not usable
> >Confidential:   no
> >Severity:       critical
> >Priority:       high
> >Responsible:    freebsd-bugs
> >State:          open
> >Quarter:        
> >Keywords:       
> >Date-Required:
> >Class:          sw-bug
> >Submitter-Id:   current-users
> >Arrival-Date:   Thu Jan 31 21:20:01 UTC 2008
> >Closed-Date:
> >Last-Modified:
> >Originator:     Nicolae Namolovan
> >Release:        RELENG_7_0 from 31.01.2008
> >Organization:
> >Environment:
> [root@centru /sys/modules/geom/geom_vinum]# uname -a
> FreeBSD centru.md 7.0-RC1 FreeBSD 7.0-RC1 #1: Thu Jan 31 20:35:48 EET 2008     adrenalin@centru.md:/usr/obj/usr/src/sys/GOGOASHA  amd64
> >Description:
> Current gvinum is not usable, yesterday I got a kernel panic.
> 
> http://lists.freebsd.org/pipermail/freebsd-geom/2007-November/002683.html I saw the same problem on the mail list, yet not fixed..
> 
> I heard there is some patches from Google Sumer Code ? Anyway, I can't manage to compile them, this is what I get..
> http://people.freebsd.org/~lulf/patches/gvinum/gvinum_2007-11-03_RELENG_7.diff
> 
> ===> geom_vinum (all)
> cc -O2 -march=nocona -fno-strict-aliasing  -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef - Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c
[...]

I replied to this in private, but I'll post it here also to get it into
GNATS:

Hi,

Glad to hear someone is trying my patches out :)

I just tried it, and it works on RELENG_7_0. From the errors you get, it
looks like you've tried to apply the patch twice (since you get redifenition
of function XXX all the time). Also, the kproc_ warning seems strange, but
might come if you run 6.x and compile 7.0.

So, make sure you have a clean geom tree. Try and rm -rf
sys/geom/vinum
sys/modules/geom/geom_vinum
sbin/gvinum

do a csup, and try to apply the patch again.

In case you applied it to the wrong place the first time, the patch is to be
applied to /usr/src

-- 
Ulf Lilleengen
Comment 4 Ulf Lilleengen freebsd_committer freebsd_triage 2008-02-11 18:05:58 UTC
State Changed
From-To: open->feedback

- A solution proposal have been posted.
Comment 5 Nicolae Namolovan 2008-02-11 19:34:32 UTC
Unfortunately I don't have more time for testing.. Already using ZFS,
seem to working fine..

On Feb 11, 2008 6:38 PM, Ulf Lilleengen <lulf@stud.ntnu.no> wrote:
> On tor, jan 31, 2008 at 09:14:35pm +0000, Nicolae Namolovan wrote:
> >
> > >Number:         120192
> > >Category:       kern
> > >Synopsis:       Current gvinum is not usable
> > >Confidential:   no
> > >Severity:       critical
> > >Priority:       high
> > >Responsible:    freebsd-bugs
> > >State:          open
> > >Quarter:
> > >Keywords:
> > >Date-Required:
> > >Class:          sw-bug
> > >Submitter-Id:   current-users
> > >Arrival-Date:   Thu Jan 31 21:20:01 UTC 2008
> > >Closed-Date:
> > >Last-Modified:
> > >Originator:     Nicolae Namolovan
> > >Release:        RELENG_7_0 from 31.01.2008
> > >Organization:
> > >Environment:
> > [root@centru /sys/modules/geom/geom_vinum]# uname -a
> > FreeBSD centru.md 7.0-RC1 FreeBSD 7.0-RC1 #1: Thu Jan 31 20:35:48 EET 2008     adrenalin@centru.md:/usr/obj/usr/src/sys/GOGOASHA  amd64
> > >Description:
> > Current gvinum is not usable, yesterday I got a kernel panic.
> >
> > http://lists.freebsd.org/pipermail/freebsd-geom/2007-November/002683.html I saw the same problem on the mail list, yet not fixed..
> >
> > I heard there is some patches from Google Sumer Code ? Anyway, I can't manage to compile them, this is what I get..
> > http://people.freebsd.org/~lulf/patches/gvinum/gvinum_2007-11-03_RELENG_7.diff
> >
> > ===> geom_vinum (all)
> > cc -O2 -march=nocona -fno-strict-aliasing  -D_KERNEL -DKLD_MODULE -std=c99 -nostdinc   -I. -I@ -I@/contrib/altq -finline-limit=8000 --param inline-unit-growth=100 --param large-function-growth=1000 -fno-common  -fno-omit-frame-pointer -mcmodel=kernel -mno-red-zone  -mfpmath=387 -mno-sse -mno-sse2 -mno-mmx -mno-3dnow  -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -Wall -Wredundant-decls -Wnested-externs -Wstrict-prototypes  -Wmissing-prototypes -Wpointer-arith -Winline -Wcast-qual  -Wundef  -Wno-pointer-sign -fformat-extensions -c /usr/src/sys/modules/geom/geom_vinum/../../../geom/vinum/geom_vinum.c
> [...]
>
> I replied to this in private, but I'll post it here also to get it into
> GNATS:
>
> Hi,
>
> Glad to hear someone is trying my patches out :)
>
> I just tried it, and it works on RELENG_7_0. From the errors you get, it
> looks like you've tried to apply the patch twice (since you get redifenition
> of function XXX all the time). Also, the kproc_ warning seems strange, but
> might come if you run 6.x and compile 7.0.
>
> So, make sure you have a clean geom tree. Try and rm -rf
> sys/geom/vinum
> sys/modules/geom/geom_vinum
> sbin/gvinum
>
> do a csup, and try to apply the patch again.
>
> In case you applied it to the wrong place the first time, the patch is to be
> applied to /usr/src
>
> --
> Ulf Lilleengen
>



-- 
Sincerely,
Nicolae Namolovan.
Comment 6 Ulf Lilleengen freebsd_committer freebsd_triage 2008-02-11 19:44:48 UTC
State Changed
From-To: feedback->closed
Comment 7 Ulf Lilleengen freebsd_committer freebsd_triage 2008-02-11 19:50:19 UTC
State Changed
From-To: closed->feedback

- Closed this by an error.
Comment 8 Ulf Lilleengen freebsd_committer freebsd_triage 2008-03-04 13:26:53 UTC
State Changed
From-To: feedback->closed

- The patch have been verified to work against a clean source tree.