Bug 120277
| Summary: | Mk/bsd.lua.mk : set ${PREFIX} to LUA_PREFIX rather than ${LOCALBASE} | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Hirohisa Yamaguchi <umq> |
| Component: | Individual Port(s) | Assignee: | Alejandro Pulver <alepulver> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-ports-bugs->alepulver bsd.lua.mk is alepulver territory (via the GNATS Auto Assign Tool) alepulver 2008-02-09 23:11:51 UTC
FreeBSD ports repository
Modified files:
Mk bsd.lua.mk
Log:
- Change LUA_PREFIX default value from LOCALBASE to PREFIX.
Actually the Lua prefix should be recorded on each port and read from there
(as with "*-config --prefix" scripts), instead of this assumption. But
supporting PREFIX is a requirement, while supporting different custom
combinations of a general PREFIX for dependencies and a different PREFIX for a
specific port is not. Also the latter could be achieved by changing LOCALBASE
too, or directly modifying LUA_PREFIX in this case.
PR: ports/120277
Submitted by: Hirohisa Yamaguchi <umq@ueo.co.jp>
Revision Changes Path
1.15 +2 -2 ports/Mk/bsd.lua.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Fix committed, thanks. Hi!
Please revert this. While fixing lua with changed PREFIX, this
breaks (almost) all ports that use LUA with changed prefix, as they
rely on LUA_{INC,LIB}DIR to find LUA libs.
For example, 3 of 4 my port that use LUA_INCDIR are not broken:
# cd /usr/ports/ports-mgmt/porttools && make install
then
# cd /usr/ports/devel/luabind && port test
[won't build]
# cd /usr/ports/games/allacrost && port test
[won't build]
# cd /usr/ports/games/xmoto && port test
[won't build]
I don't think than handling non-leaf ports installed with non-default
prefix is supported in FreeBSD, so the behavior for lua should not be
changed either.
Btw, the original PR relies to broken plist of lang/lua:
`When I installed lang/lua with PREFIX set, LUA_BINDIR,
LUA_INCDIR and LUA_LIBDIR were fixed under ${LOCALBASE} and
pkg_delete did not work.'
This should be fixed in lang/lua, as actually LUA_* should be never used
in lua port itself.
--
Dmitry A. Marakasov | jabber: amdmi3@jabber.ru
amdmi3@amdmi3.ru | http://www.amdmi3.ru
alepulver 2008-02-18 18:41:27 UTC
FreeBSD ports repository
Modified files:
Mk bsd.lua.mk
Log:
- Fix defining Lua include/library directories under PREFIX (last commit) [1].
- Now LUA_PREFIX has 2 functions: for Lua ports indicate where to install, and
for dependencies indicate where Lua is installed (check new comments inside
bsd.lua.mk for more information).
PR: ports/120277
Submitted by: Hirohisa Yamaguchi <umq@ueo.co.jp>
Reported by: Dmitry Marakasov <amdmi3@amdmi3.ru> [1]
Revision Changes Path
1.16 +27 -6 ports/Mk/bsd.lua.mk
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
When I installed lang/lua with PREFIX set, LUA_BINDIR, LUA_INCDIR and LUA_LIBDIR were fixed under ${LOCALBASE} and pkg_delete did not work. Fix: Set ${PREFIX} to LUA_PREFIX in Mk/bsd.lua.mk Although adding ``LUA_PREFIX=\${PREFIX}'' to MAKE_ARGS can be a work around. How-To-Repeat: cd ports/lang/lua make install PREFIX=/_SOME_/_PATH_