Bug 121428
| Summary: | [patch] x11/xlockmore: fix Mesa/GL modes | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Oliver Fromme <olli> | ||||
| Component: | Individual Port(s) | Assignee: | freebsd-ports-bugs (Nobody) <ports-bugs> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | CC: | olli | ||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
State Changed From-To: open->closed Committed. Thanks! miwi 2008-03-13 11:33:44 UTC
FreeBSD ports repository
Modified files:
x11/xlockmore Makefile
Log:
- Fix Mesa/GL modes
PR: 121428
Submitted by: Oliver Fromme <olli@secnetix.de>
Revision Changes Path
1.109 +4 -4 ports/x11/xlockmore/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
The options switch "Enable Mesa 3D (for GL modes)" is broken. In fact it's broken in a very interesting way. :-) It turns out that these lines are the culprit: OPTIONS=MESAGL "Enable Mesa 3D (for GL modes)" off .if ${ARCH} == amd64 WITH_MESAGL= no .else WITH_MESAGL?= yes .endif .if ${WITH_MESAGL} == yes CONFIGURE_ARGS+= --with-mesa First case: options MESAGL is *disabled*. Then the options framework sets the variable WITHOUT_MESAGL=true. The above code (running on non-amd64) then sets WITH_MESAGL=yes anyway enabling Mesa support even though the user didn't want it. Second case: options MESAGL is *enabled*. As a result, the variable WITH_MESAGL is set to "true" (not "yes"!). The above code only checks for the value "yes", therefore *not* enabling Mesa support. How-To-Repeat: On a FreeBSD/i386 machine: cd /usr/ports/x11/xlockmore make config make Notice that Mesa/GL modes are *not* included if you enabled them in the config menu. Notice that they *are* included if you disabled them.