Bug 121431

Summary: devel/ccrtp doesn't build with security/libgcrypt 1.4.0 on FreeBSD 5.x
Product: Ports & Packages Reporter: Jonathan Lennox <lennox>
Component: Individual Port(s)Assignee: Jose Alonso Cardenas Marquez <acm>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Jonathan Lennox 2008-03-06 16:10:03 UTC 
With version 1.4.0 of security/libgcrypt, the devel/ccrtp port doesn't build
on FreeBSD 5.x.

This appears to be due to devel/ccrtp building as C++ with the -pedantic
flag, while gcrypt.h has enumerator lists (gcry_ac_em_t and
gcry_ac_scheme_t) with trailing commas.  This causes a compiler error with
the FreeBSD 5.x g++.

/bin/sh ../libtool --tag=CXX   --mode=compile c++ -DHAVE_CONFIG_H -I.   -I/usr/local/include  -Wall -ansi -pedantic -O -pipe -march=athlon-xp -D_THREAD_SAFE -D_GNU_SOURCE -I/usr/local/include   -c -o gcrypthmac.lo `test -f 'ccrtp/crypto/gcrypt/gcrypthmac.cxx' || echo './'`ccrtp/crypto/gcrypt/gcrypthmac.cxx
 c++ -DHAVE_CONFIG_H -I. -I/usr/local/include -Wall -ansi -pedantic -O -pipe -march=athlon-xp -D_THREAD_SAFE -D_GNU_SOURCE -I/usr/local/include -c ccrtp/crypto/gcrypt/gcrypthmac.cxx  -fPIC -DPIC -o .libs/gcrypthmac.o
In file included from ccrtp/crypto/gcrypt/gcrypthmac.cxx:23:
/usr/local/include/gcrypt.h:1238: error: comma at end of enumerator list
/usr/local/include/gcrypt.h:1246: error: comma at end of enumerator list
gmake[3]: *** [gcrypthmac.lo] Error 1
gmake[3]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake[2]: *** [all-recursive] Error 1
gmake[2]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake[1]: *** [all] Error 2
gmake[1]: Leaving directory `/usr/ports/devel/ccrtp/work/ccrtp-1.6.0/src'
gmake: *** [all-recursive] Error 1
*** Error code 2

Stop in /usr/ports/devel/ccrtp.


This issue has been reported to the libgcrypt bug tracker.

Fix: The proper fix should probably be to the security/libgcrypt port, but adding
the following patch file to devel/ccrtp/files fixes the ccrtp build:
How-To-Repeat: 
portupgrade security/libgcrypt
portinstall -f devel/ccrtp
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-03-06 16:10:15 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->acm

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Alonso Cárdenas Márquez 2008-05-20 01:25:31 UTC 
Hi :)

Could you test if it works with lastest version of security/libgcrypt?
because a similar problem was reported with fbsd 7, but i can't
reproduce the problem on 7-STABLE, 6-STABLE (i386, amd64).

Greeting
ACM
Comment 3 Martin Wilke freebsd_committer freebsd_triage 2008-06-01 17:49:53 UTC 
State Changed
From-To: open->closed

FreeBSD 5 is now EOL. Please update to 6.4 or 7.0 Thanks.