Bug 121487

Summary: Another typos in gmultipath.8
Product: Documentation Reporter: Anatoly Borodin <anatoly.borodin>
Component: Books & ArticlesAssignee: Christian Brueffer <brueffer>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Anatoly Borodin 2008-03-08 04:50:01 UTC
/usr/src/sbin/geom/class/multipath/gmultipath.8 contains

"    You can then use the gmultipath command to label and create the MULTIPATH
     GEOM class named Fred.

           gmultipath label -v Fred /dev/da0 /dev/da2
           disklabel -Brw /dev/multipath/Fred auto
           newfs /dev/multipath/Freda
           mount /dev/mutlpath/Freda /mnt...."

Sometimes "Fred", sometimes "Freda".
Comment 1 Christian Brueffer freebsd_committer freebsd_triage 2008-03-08 12:18:13 UTC
On Sat, Mar 08, 2008 at 04:41:54AM +0000, Anatoly Borodin wrote:
> /usr/src/sbin/geom/class/multipath/gmultipath.8 contains
> 
> "    You can then use the gmultipath command to label and create the MULTIPATH
>      GEOM class named Fred.
> 
>            gmultipath label -v Fred /dev/da0 /dev/da2
>            disklabel -Brw /dev/multipath/Fred auto
>            newfs /dev/multipath/Freda
>            mount /dev/mutlpath/Freda /mnt...."
> 
> Sometimes "Fred", sometimes "Freda".
> 


Hi Anatoly, the Freda is Fred after the disklabel, the appended a simply
being the created partition.  So, Fred vs Freda is correct, although I
admit it's looks a little weird.

Any suggestion on how to improve the naming?

- Christian

-- 
Christian Brueffer	chris@unixpages.org	brueffer@FreeBSD.org
GPG Key:	 http://people.freebsd.org/~brueffer/brueffer.key.asc
GPG Fingerprint: A5C8 2099 19FF AACA F41B  B29B 6C76 178C A0ED 982D
Comment 2 Anatoly Borodin 2008-03-08 12:59:27 UTC
Hi!

On Sat, Mar 8, 2008 at 2:18 PM, Christian Brueffer <brueffer@freebsd.org>
wrote:

> On Sat, Mar 08, 2008 at 04:41:54AM +0000, Anatoly Borodin wrote:
> > /usr/src/sbin/geom/class/multipath/gmultipath.8 contains
> >
> > "    You can then use the gmultipath command to label and create the
> MULTIPATH
> >      GEOM class named Fred.
> >
> >            gmultipath label -v Fred /dev/da0 /dev/da2
> >            disklabel -Brw /dev/multipath/Fred auto
> >            newfs /dev/multipath/Freda
> >            mount /dev/mutlpath/Freda /mnt...."
> >
> > Sometimes "Fred", sometimes "Freda".
> >
>
> Hi Anatoly, the Freda is Fred after the disklabel, the appended a simply
> being the created partition.  So, Fred vs Freda is correct, although I
> admit it's looks a little weird.
>
> Any suggestion on how to improve the naming?


Maybe use "FRED" instead? I've no other suggestions.


-- 
Mit freundlichen GrüÃen,
Anatoly Borodin
business: anatoly.borodin@gmail.com
privat: fractalizator@gmail.com
Comment 3 Volker 2008-03-09 01:51:34 UTC
What about a change like this?

--- gmultipath.8.orig	2008-03-09 02:49:58.000000000 +0100
+++ gmultipath.8	2008-03-09 02:50:22.000000000 +0100
@@ -220,6 +220,7 @@
 .Bd -literal -offset indent
 gmultipath label -v Fred /dev/da0 /dev/da2
 disklabel -Brw /dev/multipath/Fred auto
+# now create a filesystem on label a of the provider
 newfs /dev/multipath/Freda
 mount /dev/mutlpath/Freda /mnt....
 .Ed
Comment 4 Anatoly Borodin 2008-03-09 10:55:41 UTC
Hi!


On Sun, Mar 9, 2008 at 3:51 AM, Volker <volker@vwsoft.com> wrote:

> What about a change like this?
>
> --- gmultipath.8.orig   2008-03-09 02:49:58.000000000 +0100
> +++ gmultipath.8        2008-03-09 02:50:22.000000000 +0100
> @@ -220,6 +220,7 @@
>  .Bd -literal -offset indent
>  gmultipath label -v Fred /dev/da0 /dev/da2
>  disklabel -Brw /dev/multipath/Fred auto
> +# now create a filesystem on label a of the provider
>  newfs /dev/multipath/Freda
>  mount /dev/mutlpath/Freda /mnt....
>  .Ed
>

I would agree.


-- 
Mit freundlichen GrüÃen,
Anatoly Borodin
business: anatoly.borodin@gmail.com
privat: fractalizator@gmail.com
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-03-13 15:37:07 UTC
brueffer    2008-03-13 15:37:02 UTC

  FreeBSD src repository

  Modified files:
    sbin/geom/class/multipath gmultipath.8 
  Log:
  - Use an uppercase provider name in the example, to make the name change
    after labeling the provider more obvious. (1)
  - Correct nomenclature usage
  
  PR:             121487 (1)
  Submitted by:   Anatoly Borodin <anatoly.borodin@gmail.com>
  MFC after:      3 days
  
  Revision  Changes    Path
  1.6       +7 -7      src/sbin/geom/class/multipath/gmultipath.8
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Christian Brueffer freebsd_committer freebsd_triage 2008-03-13 15:37:35 UTC
State Changed
From-To: open->patched

Applied the uppercase suggestion from the audit trail, 
thanks! 


Comment 7 Christian Brueffer freebsd_committer freebsd_triage 2008-03-13 15:37:35 UTC
Responsible Changed
From-To: freebsd-doc->brueffer

MFC reminder.
Comment 8 Christian Brueffer freebsd_committer freebsd_triage 2008-03-16 08:18:12 UTC
State Changed
From-To: patched->closed

MFC done.  Thanks!