Bug 122187

Summary: [patch] security/ipsec-tools failed build on FreeBSD 7.0 when RC5 is ON
Product: Ports & Packages Reporter: Dmitry A Grigorovich <odip>
Component: Individual Port(s)Assignee: Tom McLaughlin <tmclaugh>
Status: Closed FIXED    
Severity: Affects Only Me CC: vanhu
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-crypto_openssl.c
none
smime.p7s none

Description Dmitry A Grigorovich 2008-03-28 11:40:01 UTC
On FreeBSD 7.0 try to build security/ipsec-tools with option RC5 is ON

root@elf# cd /usr/ports/security/ipsec-tools
root@elf# make showconfig
===> The following configuration options are available for ipsec-tools-0.7:
     DEBUG=on "enable Debug support"
     IPV6=on "enable IPV6 support"
     ADMINPORT=on "enable Admin port"
     STATS=on "enable Statistics logging function"
     DPD=on "enable Dead Peer Detection"
     NATT=off "enable NAT-Traversal (kernel-patch required)"
     NATTF=off "require NAT-Traversal (fail without kernel-patch)"
     FRAG=on "enable IKE fragmentation payload support"
     HYBRID=on "enable Hybrid Mode-cfg and Xauth support"
     PAM=on "enable PAM authentication"
     GSSAPI=off "enable GSS-API authentication"
     RADIUS=off "enable Radius authentication"
     SAUNSPEC=off "enable Unspecified SA mode"
     RC5=on "enable RC5 encryption (patented)"
     IDEA=on "enable IDEA encryption (patented)"
===> Use 'make config' to modify these settings
root@elf# make build
...
cc -DHAVE_CONFIG_H -I. -I../.. -I./../libipsec   -I./../../src/racoon/missing -D_GNU_SOURCE  -DSYSCONFDIR=\"/usr/local/etc/racoon\"  -DADMINPORTDIR=\"/var/db/racoon\" -pipe -march=pentiumpro -g  -Wall -Werror -Wno-unused -DEAYDEBUG -o crypto_openssl_test.o -c ./crypto_openssl.c
cc1: warnings being treated as errors
./crypto_openssl.c: In function 'eay_rc5_encrypt':
./crypto_openssl.c:1394: warning: pointer targets in passing argument 3 of 'RC5_32_set_key' differ in signedness
./crypto_openssl.c:1402: warning: pointer targets in passing argument 1 of 'RC5_32_cbc_encrypt' differ in signedness
./crypto_openssl.c:1402: warning: pointer targets in passing argument 2 of 'RC5_32_cbc_encrypt' differ in signedness
./crypto_openssl.c:1402: warning: pointer targets in passing argument 5 of 'RC5_32_cbc_encrypt' differ in signedness
./crypto_openssl.c: In function 'eay_rc5_decrypt':
./crypto_openssl.c:1415: warning: pointer targets in passing argument 3 of 'RC5_32_set_key' differ in signedness
./crypto_openssl.c:1423: warning: pointer targets in passing argument 1 of 'RC5_32_cbc_encrypt' differ in signedness
./crypto_openssl.c:1423: warning: pointer targets in passing argument 2 of 'RC5_32_cbc_encrypt' differ in signedness
./crypto_openssl.c:1423: warning: pointer targets in passing argument 5 of 'RC5_32_cbc_encrypt' differ in signedness
*** Error code 1

Stop in /usr/ports/security/ipsec-tools/work/ipsec-tools-0.7/src/racoon.
*** Error code 1

Stop in /usr/ports/security/ipsec-tools/work/ipsec-tools-0.7/src.
*** Error code 1

Stop in /usr/ports/security/ipsec-tools/work/ipsec-tools-0.7.
*** Error code 1

Stop in /usr/ports/security/ipsec-tools/work/ipsec-tools-0.7.
*** Error code 1

Stop in /usr/ports/security/ipsec-tools.
*** Error code 1

Stop in /usr/ports/security/ipsec-tools.

==============================

On FreeBSD 6.3 bulding with same settings is OK

Fix: Add following patch to /usr/ports/security/ipsec-tools/files/
Rebuild security/ipsec-tools
How-To-Repeat: 
See above !
Comment 1 Dmitry A Grigorovich 2008-03-29 03:09:12 UTC
VANHULLEBUS Yvan wrote:
> Hi.
> 
> [RC5 compilation, patch]
> 
> Your patch seems to be ok, and will be reported to ipsec-tools 0.7.1.
> Is there some urgent need for it on FreeBSD's port, or can it wait the
> port to be upgraded to 0.7.1 (which should be released in "a few
> weeks" I guess) ?

a few weeks may be too long ...
patch works and very very simple - please include it for ipsec-tools !
 
> 
> Yvan.
>
Comment 2 Dmitry A Grigorovich 2008-03-29 03:25:00 UTC
a few weeks may be too long ...
patch works and very very simple - please include it for ipsec-tools !

-- 

[ODiP] == Grigorovich Dmitry
Comment 3 Edwin Groothuis freebsd_committer freebsd_triage 2008-03-29 04:41:44 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 4 VANHULLEBUS Yvan 2008-04-01 16:43:18 UTC
On Sat, Mar 29, 2008 at 09:09:12AM +0600, Dmitry A Grigorovich wrote:
> VANHULLEBUS Yvan wrote:
>> Hi.
>> 
>> [RC5 compilation, patch]
>> 
>> Your patch seems to be ok, and will be reported to ipsec-tools 0.7.1.
>> Is there some urgent need for it on FreeBSD's port, or can it wait the
>> port to be upgraded to 0.7.1 (which should be released in "a few
>> weeks" I guess) ?
> 
> a few weeks may be too long ...
> patch works and very very simple - please include it for ipsec-tools !


Ok, the patch has in fact already been reported to ipsec-tools 0.7
branch some weeks ago.


It is ok for me to report it in FreeBSD's port as we don't have yet an
oficial and reliable release date for 0.7.1.



Yvan.

-- 
NETASQ
http://www.netasq.com
Comment 5 Tom McLaughlin freebsd_committer freebsd_triage 2008-04-18 04:43:44 UTC
Responsible Changed
From-To: freebsd-ports-bugs->tmclaugh

Grab
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-07-08 00:59:43 UTC
tmclaugh    2008-07-07 23:59:33 UTC

  FreeBSD ports repository

  Added files:
    security/ipsec-tools/files patch-crypto_openssl.c 
  Log:
  Fix build on 7.x when RC5 support is enabled.
  
  PR:             103084, 122187
  Submitted by:   Dmitry A Grigorovich
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.1       +40 -0     ports/security/ipsec-tools/files/patch-crypto_openssl.c (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Tom McLaughlin freebsd_committer freebsd_triage 2008-07-08 01:00:28 UTC
State Changed
From-To: feedback->closed

Patch commited.