Bug 122396

Comment 1 Edwin Groothuis 2008-04-03 02:10:07 UTC

Responsible Changed
From-To: freebsd-ports-bugs->araujo

araujo@ wants his PRs (via the GNATS Auto Assign Tool)

Comment 2 Edwin Groothuis 2008-04-03 02:10:10 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

Edwin Groothuis wrote:
>
> Maintainer of mail/p5-Mail-SpamAssassin,
>
> Please note that PR ports/122396 has just been submitted.
>
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.
>
> The full text of the PR can be found at:
>     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/122396
>
> --
> Edwin Groothuis via the GNATS Auto Assign Tool
> edwin@FreeBSD.org
>
Ed: I am not sure, 100% of why this is needed, now do I know if it will 
break something

I do see some makefiles in ports with a /g after them, and I don't know 
if this is being requested because a user had a problem, since there is 
no documentation on WHY the change is requested, or what happens if you 
don't do it.

I personally have never had anyone report a problem, and 300 systems I 
maintain in the field have never reported a problem.

If you know 100% for sure they won't break something, apply it.  If not, 
since there has never been even one report of a problem, don't apply it.

-MASTER_SITES=  ${MASTER_SITE_APACHE:S/$/:apache/} 
${MASTER_SITE_PERL_CPAN:S/$/:cpan/}
+MASTER_SITES=  ${MASTER_SITE_APACHE:S/$/:apache/g} 
${MASTER_SITE_PERL_CPAN:S/$/:cpan/g}


-- 
Michael Scheidell, CTO
Main: 561-999-5000, Office: 561-939-7259
 > *| *SECNAP Network Security Corporation
Winner 2008 Technosium hot company award.
www.technosium.com/hotcompanies/ <http://www.technosium.com/hotcompanies/>


_________________________________________________________________________
This email has been scanned and certified safe by SpammerTrap(tm). 
For Information please see http://www.spammertrap.com
_________________________________________________________________________

Comment 4 Marcelo Araujo 2008-04-08 05:22:10 UTC

State Changed
From-To: feedback->open

I'm waiting a major UPDATE, maintainer is not sure 100% and this seems a 
minor update.

Maintainer is correct, both flz@ and I are wrong:

Please close PR, that'll teach me to listen to a portmgr@.

for proof,
make -V MASTER_SITES


S/old_string/new_string/[g]:
Modify the first occurrence of old_string in each word of the
variable's value, replacing it with new_string.  If a `g' is
appended to the last slash of the pattern, all occurrences in
each word are replaced.  If old_string begins with a caret
(`^'), old_string is anchored at the beginning of each word.
If old_string ends with a dollar sign (`$'), it is anchored
at the end of each word.  Inside new_string, an ampersand
(`&') is replaced by old_string.  Any character may be used
as a delimiter for the parts of the modifier string.  The
anchoring, ampersand, and delimiter characters may be escaped
with a backslash (`\').

Variable expansion occurs in the normal fashion inside both
old_string and new_string with the single exception that a
backslash is used to prevent the expansion of a dollar sign
(`$'), not a preceding dollar sign as is usual.

Comment 6 Marcelo Araujo 2008-04-15 11:41:01 UTC

State Changed
From-To: open->closed

Submitter request it. Closed!