Bug 122555
| Summary: | [PATCH] devel/apr: update to 1.2.12 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Philip M. Gollucci <pgollucci> | ||||||
| Component: | Individual Port(s) | Assignee: | Marcelo Araujo <araujo> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | rodrigc | ||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Philip M. Gollucci
2008-04-08 07:10:11 UTC
Responsible Changed From-To: freebsd-ports-bugs->araujo araujo@ wants his PRs (via the GNATS Auto Assign Tool) State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Note that files/patch-apr-util_build_dbm.m4 [1] has been submitted up stream to dev@apr.apache.org. This will also let us remove files/patch-apr-util_configure [2] as this diff is generated by re-runing ./buildconf after [1] has been modified. I'll respond back with the SVN revisions and branches its applied to. -- ------------------------------------------------------------------------ Philip M. Gollucci (philip@ridecharge.com) o:703.549.2050x206 Senior System Admin - Riderway, Inc. http://riderway.com / http://ridecharge.com 1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. dev@apr.apache.org said this patch was wrong, should use LDFLAGS not LIBS. I'll submit another diff in a day or 2. -- ------------------------------------------------------------------------ Philip M. Gollucci (philip@ridecharge.com) o:703.549.2050x206 Senior System Admin - Riderway, Inc. http://riderway.com / http://ridecharge.com 1024D/EC88A0BF 0DE5 C55C 6BF3 B235 2DAB B89E 1324 9B4F EC88 A0BF Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 http://svn.apache.org/viewvc?rev=649458&view=rev on trunk, awaiting MFC to branches/1_3_x and branches/1_2_x - -- - ------------------------------------------------------------------------ Philip M. Gollucci (philip@ridecharge.com) o:703.549.2050x206 Senior System Admin - Riderway, Inc. http://riderway.com / http://ridecharge.com 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFICQiCdbiP+9ubjBwRAnioAKCFmPqaL5Z9ED5MEJt50s+CIP85jwCfYGnP /7LrKd9z84mKMYGy7IL7pWE= =sZXF -----END PGP SIGNATURE----- Hi, The patch you submitted doesn't look fully baked. I'll wait until you get more feedback from the apr team. When you submit a patch: -> don't submit unnecessary whitespace chagnes -> why did you remove the patch for apr_hints.m4? That patch is necessary for the chroot'd environment for how the ports cluster builds this port -- Craig Rodrigues rodrigc@crodrigues.org State Changed From-To: feedback->open Feedback received, I'm waiting next steps. -----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 branches/1.3.x http://svn.apache.org/viewvc?rev=650676&view=rev branches/1.2.x http://svn.apache.org/viewvc?rev=650677&view=rev Horray! -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.8 (FreeBSD) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFID2WxdbiP+9ubjBwRAgGQAKCOzl9/T/wsHlxRBnUKKQLcanclCwCeJBYo ekOryFbi2BEM4SyOphMlDX0= =qvPG -----END PGP SIGNATURE----- State Changed From-To: open->feedback How goes this PR? Any solution? Hi, Sorry, I wasn't thinking about pointyhat when I removed that patch before. I should have read the CVS logs more carefully. I didn't change any whitespace. Attached is the final patch. State Changed From-To: feedback->closed I disagree with most of this patch, so will not commit it. However, I did upgrade the port to 1.2.12 Like um, its part of APR/APR-UTIL when 1.3.0 comes out in < 1 week. This should be fun..... |
