Bug 122714
| Summary: | [patch] ports/net/vnc build failure WITHOUT_SERVER | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Helge Oldach <ports-net-vnc-apr08> |
| Component: | Individual Port(s) | Assignee: | Anders Nordby <anders> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | james |
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Responsible Changed From-To: freebsd-ports-bugs->anders As I did the update on this port, I will also handle this PR. anders 2008-04-15 22:23:56 UTC
FreeBSD ports repository
Modified files:
net/vnc Makefile
Removed files:
net/vnc/files patch-xc-config-util-printver.c
Log:
Fix build when WITHOUT_SERVER is set.
PR: 122714
Submitted by: Helge Oldach <ports-net-vnc-apr08@oldach.net>
Approved by: maintainer timeout
Revision Changes Path
1.53 +2 -1 ports/net/vnc/Makefile
1.2 +0 -10 ports/net/vnc/files/patch-xc-config-util-printver.c (dead)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed I have fixed this now. Thanks for reporting. |
ports/net/vnc does not patch properly when WITHOUT_SERVER is enabled: # make -DPATCH_DEBUG ===> Vulnerability check disabled, database not found ===> Found saved configuration for vnc-4.1.2_2 ===> Extracting for vnc-4.1.2_2 => MD5 Checksum OK for xc/vnc-4_1_2-unixsrc.tar.gz. => SHA256 Checksum OK for xc/vnc-4_1_2-unixsrc.tar.gz. ===> Patching for vnc-4.1.2_2 ===> Applying FreeBSD patches for vnc-4.1.2_2 ===> Applying FreeBSD patch /usr/ports/net/vnc/files/patch-xc-config-util-printver.c Hmm... Looks like a unified diff to me... The text leading up to this was: -------------------------- |--- xc/config/util/printver.c.orig 2003-02-26 10:21:33.000000000 +0100 |+++ xc/config/util/printver.c 2008-03-16 10:07:56.000000000 +0100 -------------------------- File to patch: The reason is that all files following the ${PATCHDIR}/patch* naming scheme are applied automatically and unconditionally. This includes files/patch-xc-config-util-printver.c which is only applicable for WITH_SERVER builds. Fix: Rename ${PATCHDIR}/patch-xc-config-util-printver.c to ${PATCHDIR}/extra-patch-xc-config-util-printver.c and add ${PATCHDIR}/extra-patch-xc-config-util-printver.c to EXTRA_PATCHES in Makefile.