Bug 122906

Summary: [patch] Fix makevar, maketarget Tags in Handbook Chapter 4.
Product: Documentation Reporter: Gabor Pali <pgj>
Component: Books & ArticlesAssignee: freebsd-doc (Nobody) <doc>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
ports.patch.diff none

Description Gabor Pali freebsd_committer freebsd_triage 2008-04-19 12:00:01 UTC 
	I found a small inconsistency in the use of maketarget, makevar
	tags in SGML source of the Handbook chapter titled ``Packages and
	Ports''. So, I created a patch to unify their usage and
	<command>make <maketarget>all consistent</maketarget></command>
	in the <makevar>PORTS_CHAPTER</makevar> :)

Fix: Apply the following patch:
Comment 1 Marc Fonvieille freebsd_committer freebsd_triage 2008-04-19 12:46:43 UTC 
Hello,

This patch mixes content and whitespace/wrapline changes.  We use to
not commit changes to the content at the same time as changes to the
layout.  These changes must be done in 2 separated patches, well most of
time we don't do the formatting changes or only when the file starts to
be a mess.
To come back to the content, the changes seem Ok for me but please
send a content changes only patch.

-- 
Marc
Comment 2 Gabor Pali freebsd_committer freebsd_triage 2008-04-19 13:02:00 UTC 
Dear Marc,

Thank you for your comment, it will be done. I know the rule you pointed
out, although I thought the patch will not break it.

Should I "invalidate" this PR or can I edit it in some way?


Cheers,
-pgj


PS: Is this a right way to send my patches to (peer) review?
Comment 3 Gabor Pali freebsd_committer freebsd_triage 2008-04-22 16:51:10 UTC 
State Changed
From-To: open->closed

Submitted in a wrong format, I'll send again.