Bug 123109

Summary: [libc] Remove dead static variable from implementation of fdopen()
Product: Base System Reporter: Christoph Mallon <christoph.mallon>
Component: kernAssignee: Antoine Brodin <antoine>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Christoph Mallon 2008-04-26 11:30:00 UTC 
The implementation of fdopen() contains the static variable nofile, which only gets tested to assign to it, but is not used otherwise. This variable is dead since revision 1.1 of this file.

Fix: Apply the patch, which removes this static variable.

Patch attached with submission follows:
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2008-04-26 18:55:48 UTC 
Responsible Changed
From-To: freebsd-bugs->antoine

Take.
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-05-10 19:39:28 UTC 
antoine     2008-05-10 18:39:20 UTC

  FreeBSD src repository

  Modified files:
    lib/libc/stdio       fdopen.c 
  Log:
  Remove useless call to getdtablesize(2) in fdopen(3) and its useless
  variable nofile.
  
  PR:             123109
  Submitted by:   Christoph Mallon
  Approved by:    rwatson (mentor)
  MFC after:      1 month
  
  Revision  Changes    Path
  1.11      +0 -4      src/lib/libc/stdio/fdopen.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2008-05-10 19:51:57 UTC 
State Changed
From-To: open->patched

Patched in HEAD.
Comment 4 dfilter service freebsd_committer freebsd_triage 2008-07-28 20:35:55 UTC 
antoine     2008-07-28 19:35:26 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_7)
    lib/libc/stdio       fdopen.c 
  Log:
  SVN rev 180933 on 2008-07-28 19:35:26Z by antoine
  
  MFC r178921 to stable/7:
    Remove useless call to getdtablesize(2) in fdopen(3) and its useless
    variable nofile.
  
    PR:             123109
    Submitted by:   Christoph Mallon
    Approved by:    rwatson (mentor)
    MFC after:      1 month
  
  Revision  Changes    Path
  1.8.2.2   +0 -4      src/lib/libc/stdio/fdopen.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-07-28 20:37:55 UTC 
antoine     2008-07-28 19:37:26 UTC

  FreeBSD src repository

  Modified files:        (Branch: RELENG_6)
    lib/libc/stdio       fdopen.c 
  Log:
  SVN rev 180934 on 2008-07-28 19:37:26Z by antoine
  
  MFC r178921 to stable/6:
    Remove useless call to getdtablesize(2) in fdopen(3) and its useless
    variable nofile.
  
    PR:             123109
    Submitted by:   Christoph Mallon
    Approved by:    rwatson (mentor)
    MFC after:      1 month
  
  Revision  Changes    Path
  1.7.14.2  +0 -4      src/lib/libc/stdio/fdopen.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Antoine Brodin freebsd_committer freebsd_triage 2008-07-28 20:47:56 UTC 
State Changed
From-To: patched->closed

Close: fix committed in head, releng_6 and releng_7. 
Thanks for the report!