Bug 123469

Summary: [PATCH] net/rsync: fix WITHOUT_ICONV build
Product: Ports & Packages Reporter: Dan Nelson <dnelson>
Component: Individual Port(s)Assignee: Emanuel Haupt <ehaupt>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Dan Nelson 2008-05-06 17:40:04 UTC 
	

The options dialog lets you ask for iconv support to be disabled, but
just adding --disable-iconv isn't enough.  That simply disables rsync's
--iconv flag but still allows libiconv to be linked into the binary...

Fix: Set the appropriate autoconf cache variables so that rsync's configure
script completely skips iconv detection, even if it's present on the
system.  As a bonus, no post-configure fixup is needed:
How-To-Repeat: 	

Install libiconv, uncheck "Add iconv support" in the rsync options
screen, build rsync.  The link stage will fail with:

rsync.o(.text+0xffe): In function `iconvbufs':
: undefined reference to `libiconv'
rsync.o(.text+0x1132): In function `iconvbufs':
: undefined reference to `libiconv'
rsync.o(.text+0x11b8): In function `setup_iconv':
: undefined reference to `locale_charset'
rsync.o(.text+0x11de): In function `setup_iconv':
: undefined reference to `libiconv_open'
*** Error code 1
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-05-06 17:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->ehaupt

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-05-07 13:32:27 UTC 
ehaupt      2008-05-07 12:32:17 UTC

  FreeBSD ports repository

  Modified files:
    net/rsync            Makefile 
  Log:
  Rework WITHOUT_ICONV build option
  
  PR:             123469
  Submitted by:   Dan Nelson <dnelson@allantgroup.com>
  
  Revision  Changes    Path
  1.132     +3 -6      ports/net/rsync/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Emanuel Haupt freebsd_committer freebsd_triage 2008-05-07 13:32:35 UTC 
State Changed
From-To: open->closed

Even though I wasn't able to reproduce the linker error this is a much nicer 
approach  to work arround the w/o iconv issue. Committed, thanks!