Bug 123934
| Summary: | devel/pear-PhpDocumentor creates invalid PHP code during post-patch | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | gpalmer <gpalmer> | ||||
| Component: | Individual Port(s) | Assignee: | Martin Wilke <miwi> | ||||
| Status: | Closed FIXED | ||||||
| Severity: | Affects Only Me | ||||||
| Priority: | Normal | ||||||
| Version: | Latest | ||||||
| Hardware: | Any | ||||||
| OS: | Any | ||||||
| Attachments: |
|
||||||
Responsible Changed From-To: freebsd-ports-bugs->miwi miwi@ wants this port PRs (via the GNATS Auto Assign Tool) Maintainer of devel/pear-PhpDocumentor,
Please note that PR ports/123934 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/123934
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) The (hopefully) attached patch seems to fix the problem State Changed From-To: feedback->closed Committed. Thanks! miwi 2008-05-30 10:32:25 UTC
FreeBSD ports repository
Modified files:
devel/pear-PhpDocumentor Makefile
Log:
- Fix pear port version
PR: 123934
Submitted by: Gary Palmer
Approved by: maintainer implicit
Revision Changes Path
1.6 +1 -1 ports/devel/pear-PhpDocumentor/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
|
Part of the post-patch makefile target is a sed with the following pattern "s|VER|${PORTVERSION}|g" Unfortunately, at least one of the PHP files ( phpDocumentor/Setup.inc.php ) objects to this replacement of the string "VER". Two lines in particular: line 193: $phpdocver = PHPDOCUMENTOR_VER; line 914: if (empty($this->render->converters)) addErrorDie(PDERROR_NO_CONVERTERS) ; The code ends up as: line 193: $phpdocver = PHPDOCUMENTOR_1.4.2; line 914: if (empty($this->render->converters)) addErrorDie(PDERROR_NO_CON1.4.2TER S); neither of which parse properly PHP Parse error: syntax error, unexpected T_DNUMBER in /usr/local/share/pear/PhpDocumentor/phpDocumentor/Setup.inc.php on line 193 and PHP Parse error: syntax error, unexpected T_DNUMBER in /usr/local/share/pear/PhpDocumentor/phpDocumentor/Setup.inc.php on line 914 There may be other instances of this problem, but they can all be traced back to the post-patch target. Fix: Use PEAR directly instead of the port How-To-Repeat: cd /usr/ports/devel/devel/pear-PhpDocumentor make all install /usr/local/bin/phpdoc