Bug 124177

Summary: [patch] audio/last.fm: update to 1.4.0.56102
Product: Ports & Packages Reporter: darcsis <darcsis>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
last.fm-1.4.0.diff none

Description darcsis 2008-06-01 06:40:02 UTC 
update to 1.4.0.56102
Since this is a major release update, there are many changes to the FreeBSD patches.
All patch-* are deleted, and new patches are in this patch. Maybe it is better to use
a shar ball rather than a diff patch?
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-01 06:40:13 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->lofi

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Mark Linimon freebsd_committer freebsd_triage 2008-09-07 01:37:34 UTC 
Responsible Changed
From-To: lofi->freebsd-ports-bugs

Maintainer was reset.
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-12 15:41:59 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 4 Dmitry Marakasov 2008-09-12 16:00:37 UTC 
> Synopsis: [patch] audio/last.fm: update to 1.4.0.56102
> 
> http://www.freebsd.org/cgi/query-pr.cgi?pr=124177
Umm, is there a reson to have portaudio.h bundled with the port? We have
both version 18 and 19 of portaudio in the ports collection, won't it be
easier to make this port use on of them instead of (I assume, not looked
into sources yet) patching and building bundled portaudio?

Also, please remove trivial patches and use REINPLACE_CMD instead. At
least s|portaudio.h|pa_audio.h| should be done that way.

Finally, aren't you interested in maintaining this port?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-12 16:01:10 UTC 
State Changed
From-To: open->feedback
Comment 6 darcsis 2008-09-12 17:42:34 UTC 
Dmitry Marakasov <amdmi3@amdmi3.ru> writes:

>> Synopsis: [patch] audio/last.fm: update to 1.4.0.56102
>> 
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=124177
> Umm, is there a reson to have portaudio.h bundled with the port? We have
> both version 18 and 19 of portaudio in the ports collection, won't it be
> easier to make this port use on of them instead of (I assume, not looked
> into sources yet) patching and building bundled portaudio?

I've not tested with the version 19 of portaudio. For version 18, the
port won't compile. I'll give it a try with the version 19 and see if it
is OK.

>
> Also, please remove trivial patches and use REINPLACE_CMD instead. At
> least s|portaudio.h|pa_audio.h| should be done that way.

OK.

>
> Finally, aren't you interested in maintaining this port?

It is OK. Recently I've been doing some qt4 stuff. This won't add much
effort I hope.

-- 
Denise H. G. <darcsis AT gmail DOT com>
Comment 7 Dmitry Marakasov 2008-09-27 11:09:59 UTC 
* Denise H. G. (darcsis@gmail.com) wrote:

> > Umm, is there a reson to have portaudio.h bundled with the port? We have
> > both version 18 and 19 of portaudio in the ports collection, won't it be
> > easier to make this port use on of them instead of (I assume, not looked
> > into sources yet) patching and building bundled portaudio?
> I've not tested with the version 19 of portaudio. For version 18, the
> port won't compile. I'll give it a try with the version 19 and see if it
> is OK.
> > Also, please remove trivial patches and use REINPLACE_CMD instead. At
> > least s|portaudio.h|pa_audio.h| should be done that way.
> OK.
So, any updates?

-- 
Dmitry Marakasov   .   55B5 0596 FF1E 8D84 5F56  9510 D35A 80DD F9D2 F77D
amdmi3@amdmi3.ru  ..:  jabber: amdmi3@jabber.ru    http://www.amdmi3.ru
Comment 8 darcsis 2008-10-25 11:59:15 UTC 
Dmitry Marakasov <amdmi3@amdmi3.ru> writes:

> * Denise H. G. (darcsis@gmail.com) wrote:
>
>> I've made some changes and cleanups. Please check them out.
> Now it's still using builtin portaudio, but with includes from
> systemwide portaudio. That's even worse :)
>
> As far as I understand, you need to modify
> src/output/portAudio/portAudio.pro to
>
> - NOT use any sources from src/output/portAudio/PortAudio
> - use -lportaduio
>

Thanks for your advice! I was really confused by those cmake makefile configurations. 


> Thus it'll use systemwide portaudio and you won't need to patch
> builtin portaudio' sources at all.
>
> PS. Please send updates as a patch to last.fm version I've attached.
> This is somehow cleaned up version, with ports/127368 merged. It'll be
> too hard to merge changes otherwise.

OK. I'll give it another try and stick to the attached version.

-- 
Denise H. G. <darcsis AT gmail DOT com>
Comment 9 Dmitry Marakasov freebsd_committer freebsd_triage 2009-03-16 01:01:53 UTC 
State Changed
From-To: feedback->closed

No activity from submitter