|Summary:||[PATCH] ports-mgmt/psearch: fix psearch does not work|
|Product:||Ports & Packages||Reporter:||Yi-Huan Chan <yhchan>|
|Component:||Individual Port(s)||Assignee:||Li-Wen Hsu <lwhsu>|
|Severity:||Affects Only Me||CC:|
Description Yi-Huan Chan 2008-06-03 04:10:01 UTC
The function Index::parse_line() should return 'true', or psearch may not work. Added file(s): - files/patch-index.cpp Port maintainer (email@example.com) is cc'd. Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis 2008-06-03 04:10:06 UTC
Maintainer of ports-mgmt/psearch, Please note that PR ports/124226 has just been submitted. If it contains a patch for an upgrade, an enhancement or a bug fix you agree on, reply to this email stating that you approve the patch and a committer will take care of it. The full text of the PR can be found at: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/124226 -- Edwin Groothuis via the GNATS Auto Assign Tool edwin@FreeBSD.org
Comment 2 Edwin Groothuis 2008-06-03 04:10:08 UTC
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Benjamin Lutz 2008-06-03 08:30:59 UTC
Hello, The PR is rejected. The submitter of the patch, Yi-Huan Chan is correct in that the problem exists (and how he suggests it be fixed), however I'd rather roll the patch into a new upstream tarball instead of having it live solely inside the ports system. I'll send a corresponding PR shortly. Yi-Huan Chan: Thanks for the code review! Cheers Benjamin
Comment 4 Li-Wen Hsu 2008-06-03 11:42:28 UTC
Responsible Changed From-To: freebsd-ports-bugs->lwhsu I'll take it.
Comment 5 dfilter service 2008-06-04 04:25:41 UTC
lwhsu 2008-06-04 03:25:35 UTC FreeBSD ports repository Modified files: ports-mgmt/psearch Makefile distinfo Log: - Update to 2.0.1, this update fixed the functionality of psearch PR: ports/124226 (based on the patch) Submitted by: Yi-Huan Chan <yhchan AT csie.nctu.edu.tw> Approved by: Benjamin Lutz <mail AT maxlor.com> (maintainer) Revision Changes Path 1.6 +1 -1 ports/ports-mgmt/psearch/Makefile 1.5 +3 -3 ports/ports-mgmt/psearch/distinfo _______________________________________________ firstname.lastname@example.org mailing list http://lists.freebsd.org/mailman/listinfo/cvs-all To unsubscribe, send any mail to "email@example.com"
Comment 6 Li-Wen Hsu 2008-06-04 04:25:48 UTC
State Changed From-To: feedback->closed Committed. Thanks!