Bug 125022

Summary: www/rt36 - upgrade RT to latest (3.6.7)
Product: Ports & Packages Reporter: falz <freebsd>
Component: Individual Port(s)Assignee: Wesley Shields <wxs>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
patch-rt367.diff none

Description falz 2008-06-26 20:20:01 UTC
Update RT to latest (3.6.7). Added one dependency with a version check:

	devel/p5-Devel-StackTrace

and changed these dependencies to check version numbers:

	databases/p5-DBIx-SearchBuilder
	www/p5-CGI.pm

These were done based on the release announcement for 3.6.7:

	http://lists.bestpractical.com/pipermail/rt-announce/2008-June/000157.html

I opted to simply put these under PERL_MODULES with the other dependencies, but 
considered putting them under BUILD_DEPENDS or RUN_DEPENDS, all of which would
currently yield the same results.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-26 20:20:16 UTC
Maintainer of www/rt36,

Please note that PR ports/125022 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/125022

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-06-26 20:20:19 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Vick Khera 2008-06-26 21:24:18 UTC
Thanks!

Did you test it with "make clean" to see if any files were missing or  
left behind?

I won't be able to get to that for a couple of days, but that's my  
only concern with your patch.  If it passes cleanly with make clean  
leaving nothing behind, I'm all for committing this.
Comment 4 falz 2008-06-26 21:44:05 UTC
On Thu, Jun 26, 2008 at 3:24 PM, Vivek Khera <vivek@khera.org> wrote:
> Thanks!
>
> Did you test it with "make clean" to see if any files were missing or left
> behind?

This was done. In fact, the diff to create the patch was made from a
directory structure that did have 'work' in it and was installed from
a few times, and cleaned up only using 'make clean'.

> I won't be able to get to that for a couple of days, but that's my only
> concern with your patch.  If it passes cleanly with make clean leaving
> nothing behind, I'm all for committing this.

Sounds good. The reason I submitted the patch was simply because I was
about to upgrade from 3.6.5 to 3.6.6, noticed that 3.6.7 was out, and
figured I'd rather just upgrade once instead of twice.

Note that when creating the patch, my only concern is that the old way
of checking for the 3 updated dependencies would hit patches installed
from cpan/bsdpan. The new way may force them to be installed from via
ports, which shouldn't hurt anything/may be a good thing.

--falz
Comment 5 Wesley Shields freebsd_committer freebsd_triage 2008-06-28 03:58:21 UTC
Responsible Changed
From-To: freebsd-ports-bugs->wxs

I'll take it.
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-07-02 15:33:54 UTC
wxs         2008-07-02 14:33:44 UTC

  FreeBSD ports repository

  Modified files:
    www/rt36             Makefile distinfo 
  Log:
  Update to 3.6.7
  This port now has minimum version requirements:
  p5-CGI.pm >= 3.10
  p5-DBIx-SearchBuilder >= 0.53
  p5-Devel-StackTrace >= 1.19
  
  PR:             ports/125022
  Submitted by:   falz <freebsd@falz.net>
  Approved by:    maintainer
  
  Revision  Changes    Path
  1.66      +4 -4      ports/www/rt36/Makefile
  1.29      +6 -6      ports/www/rt36/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Wesley Shields freebsd_committer freebsd_triage 2008-07-02 15:34:02 UTC
State Changed
From-To: feedback->closed

Committed. Thanks!