Bug 125765

Summary: Change for the editors/vim OPTIONS support
Product: Ports & Packages Reporter: Christoph Mallon <christoph.mallon>
Component: Individual Port(s)Assignee: David E. O'Brien <obrien>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff
none
Makefile.diff none

Description Christoph Mallon 2008-07-19 08:50:06 UTC 
I ask to apply this small change for the Makefile of editors/vim regarding the OPTIONS framework to make it work a bit more as the OPTIONS framework is described and resolve one bug:

* Move the OPTIONS from the file options into Makefile
Rationale: The standard way is to place the OPTIONS in the Makefile.
Note: Please remember to remove the file "options".

* Remove the apocryphal "WITH_OPTIONS" flag which hides the OPTIONS
Rationale: Hiding the OPTIONS is not the standard way for the OPTIONS framework. If this effect is desired, it can be achieved by the standard flag BATCH.

* Remove the apocryphal switch NO_GUI
Rationale: The prefix is incompatible with the OPTIONS framework and the flag is per construction equivalent to WITHOUT_X11.

* Change the default setting of the "X11" switch to "on"
Rationale: Building with X11 support is the default already, because the Makefile tests WITHOUT_X11 (not WITH_X11).

Fix: Patch attached with submission follows:
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-19 08:50:20 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->obrien

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 bf 2008-07-19 13:18:33 UTC 
It would be nice to have more flexible options for the port.  Two comments:

1) The recent update to patchlevel 330 broke the port on my machine, running 7-Stable i386, with the latest ports installed.  I haven't had time to track the source of the problem down yet, but it is:

...

cc -c -I. -Iproto -DHAVE_CONFIG_H -DFEAT_GUI_GTK  -D_THREAD_SAFE -I/usr/local/include/gtk-2.0 -I/usr/local/lib/gtk-2.0/include -I/usr/local/include/atk-1.0 -I/usr/local/include/cairo -I/usr/local/include/pango-1.0 -I/usr/local/include -I/usr/local/include/glib-2.0 -I/usr/local/lib/glib-2.0/include -I/usr/local/include/freetype2 -I/usr/local/include/pixman-1 -I/usr/local/include  -O2 -fno-strict-aliasing -pipe -fstack-protector-all -march=athlon-tbird  -I/usr/local/include  -DAPPLLIB_EXP="/usr/local/lib/per l5/5.8.8/BSDPAN" -DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H   -I/usr/local/include  -I/usr/local/lib/perl5/5.8.8/mach/CORE -I/usr/local/include/python2.5 -D_THREAD_SAFE -I/usr/local/include/tcl8.5 -I/usr/local/lib/ruby/1.8/i386-freebsd7  -o objects/if_python.o if_python.c
if_python.c: In function 'VimToPython':
if_python.c:1147: error: 'PRINTF_DECIMAL_LONG_U' undeclared (first use in this function)
if_python.c:1147: error: (Each undeclared identifier is reported only once
if_python.c:1147: error: for each function it appears in.)
*** Error code 1

Stop in /tmp/usr/ports/editors/vim/work/vim71/src.
*** Error code 1

Stop in /tmp/usr/ports/editors/vim/work/vim71/src.
*** Error code 1

Stop in /usr/ports/editors/vim.

2)  Since the 7.2 beta version has been out for a week (

ftp://ftp.vim.org:/pub/vim/unstable/unix/vim-7.2b.tar.bz2

), with a corresponging change in this port probably to follow soon, this comment is probably belated, but: 

The vim maintainer has started to package patches in batches of 100 in gzipped archives in the patch directory.  So, for example, there are the files

ftp://ftp.vim.org/pub/vim/patches/7.1/7.1.001-100.gz
ftp://ftp.vim.org/pub/vim/patches/7.1/7.1.101-200.gz
ftp://ftp.vim.org/pub/vim/patches/7.1/7.1.201-300.gz

At the expense of a little change in the port Makefile, these files could be used in lieu of the individual patches they comprise, the somewhat error-prone check for BADPATCHES could be discarded (since there never need be more than 99 patches), the distinfo shortened considerably, and a little internet traffic and disk space saved.

Regards, 
          b.
Comment 3 Justin Hibbits 2009-02-03 02:34:25 UTC 
Attached is a patch to fix the makefile brokenness with regard to  
options.  Even with options enabled, currently they don't work,  
because the bsd.ports.pre.mk file is included too late in the process.

Untested, but should work.
Comment 4 David E. O'Brien freebsd_committer freebsd_triage 2009-02-03 18:17:22 UTC 
State Changed
From-To: open->closed

OPTIONS procesing has issues that have yet to be addressed. 
Sorry, I'm going to close this PR without making these chagnes. 
Thing are the way they are on purpose.  I have tried to allow 
OPTIONS processing for those that want it.  If you have bugs 
in that, please let me know.
Comment 5 unixfreunde 2009-02-21 10:01:55 UTC 
David,

what exactly wouldn't work with the proposed patch, that seems all
fine to me and
WITH_VIM_OPTIONS is a undoumented knob.

see here fresh patch:
http://miwi.homeunix.com/patches/vim.diff

-- 
-- 
Martin Wilke		   | irc.unixfreunde.de #bsd
miwi@FreeBSD.org    | miwi@unixfreunde.de
FreeBSD Committer   | Power to Serve
Comment 6 David E. O'Brien freebsd_committer freebsd_triage 2009-03-12 05:08:46 UTC 
On Sat, Feb 21, 2009 at 10:30:03AM +0000, Martin Wilke wrote:
>  David,
>  what exactly wouldn't work with the proposed patch, that seems all
>  fine to me and

It seems all fine to me to leave the options in its own file.

>  WITH_VIM_OPTIONS is a undoumented knob.

How do you suggest advertising it?