Bug 125835

Comment 1 Greg Larkin 2008-07-21 19:39:58 UTC

Responsible Changed
From-To: freebsd-ports-bugs->glarkin

I'll take it.

Comment 2 Greg Larkin 2008-07-23 20:12:30 UTC

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Filipe,

Thanks very much for your PR.  I have modified the patch file somewhat
and would like your feedback on the changes I made:

- - Added another MASTER_SITES location
- - More descriptive COMMENT
- - Added requirement for PHP5 session module
- - Change pre-everything target to pre-install so upgrade message is not
echoed when running "make package"
- - Added handling for NOPORTDOCS installation
- - Rewrite do-install target to handle perms modification for package 
install
- - Install config.inc.php/config.inc.php.sample and preserve modified
config.inc.php when deinstalling
- - Rewrapped pkg-descr and displayed text to 65 chars (default fmt setting)
- - Added DOCSDIR and WWWDIR macros to pkg-plist

Here is a diff of my patch against your patch:

http://people.freebsd.org/~glarkin/diffs/ojs2-vs-submitted.diff

This is the diff against the current www/ojs2 directory in CVS, in case
you would like that, too:

http://people.freebsd.org/~glarkin/diffs/ojs2-vs-CVS.diff

Let me know what you think when you have reviewed the changes.  If you
approve of them, I will submit them to my mentor for review before
committing.

Thank you,
Greg
- --
Greg Larkin
http://www.sourcehosting.net/
http://www.FreeBSD.org/ - The Power To Serve
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIh4Ke0sRouByUApARAoMLAJ0cT66nW0DH66oNn3+MD0d7nGtNBQCghCaL
95AG1nH2efUdT44B6/qInvE=
=IlSM
-----END PGP SIGNATURE-----

Hi Greg,
Thank you for taking this. Everything seems to be fine.
Go ahead.
But first, please add another mirror: http://socpvs.org/pkp/. Please let me
know if you want another patch for this.

Thanks again,
Filipe


On Wed, Jul 23, 2008 at 8:12 PM, Greg Larkin <glarkin@freebsd.org> wrote:

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Filipe,
>
> Thanks very much for your PR.  I have modified the patch file somewhat
> and would like your feedback on the changes I made:
>
> - - Added another MASTER_SITES location
> - - More descriptive COMMENT
> - - Added requirement for PHP5 session module
> - - Change pre-everything target to pre-install so upgrade message is not
> echoed when running "make package"
> - - Added handling for NOPORTDOCS installation
> - - Rewrite do-install target to handle perms modification for package
> install
> - - Install config.inc.php/config.inc.php.sample and preserve modified
> config.inc.php when deinstalling
> - - Rewrapped pkg-descr and displayed text to 65 chars (default fmt
> setting)
> - - Added DOCSDIR and WWWDIR macros to pkg-plist
>
> Here is a diff of my patch against your patch:
>
> http://people.freebsd.org/~glarkin/diffs/ojs2-vs-submitted.diff<http://people.freebsd.org/%7Eglarkin/diffs/ojs2-vs-submitted.diff>
>
> This is the diff against the current www/ojs2 directory in CVS, in case
> you would like that, too:
>
> http://people.freebsd.org/~glarkin/diffs/ojs2-vs-CVS.diff<http://people.freebsd.org/%7Eglarkin/diffs/ojs2-vs-CVS.diff>
>
> Let me know what you think when you have reviewed the changes.  If you
> approve of them, I will submit them to my mentor for review before
> committing.
>
> Thank you,
> Greg
> - --
> Greg Larkin
> http://www.sourcehosting.net/
> http://www.FreeBSD.org/ - The Power To Serve
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.7 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFIh4Ke0sRouByUApARAoMLAJ0cT66nW0DH66oNn3+MD0d7nGtNBQCghCaL
> 95AG1nH2efUdT44B6/qInvE=
> =IlSM
> -----END PGP SIGNATURE-----
>
>

Comment 4 dfilter service 2008-07-25 19:59:25 UTC

glarkin     2008-07-25 18:59:16 UTC

  FreeBSD ports repository

  Modified files:
    .                    UPDATING 
    www/ojs2             Makefile distinfo pkg-descr pkg-message 
                         pkg-plist 
  Log:
  Updated to 2.2.1
  
  PR:             ports/125835
  Submitted by:   Filipe Rocha <filiperocha@gmail.com> (maintainer)
  Approved by:    beech (mentor)
  
  Revision  Changes      Path
  1.681     +10 -1       ports/UPDATING
  1.6       +61 -27      ports/www/ojs2/Makefile
  1.4       +3 -3        ports/www/ojs2/distinfo
  1.2       +4 -3        ports/www/ojs2/pkg-descr
  1.3       +54 -29      ports/www/ojs2/pkg-message
  1.4       +4349 -3939  ports/www/ojs2/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"

Comment 5 Greg Larkin 2008-07-25 20:05:28 UTC

State Changed
From-To: open->closed

Committed with modifications, thanks!