Bug 125907

Comment 1 Pav Lucistnik 2008-07-24 00:08:13 UTC

I fear some of the changes in this patch are incorrect:

- no WITH_APACHE recognized in Mk/*, I think WITH_APACHE2 was correct
- USE_BDB can grok values directly, ie. USE_BDB=42 instead of
  USE_BDB=yes and WITH_BDB_VERSION=42. Also please mention ranges, ie.
  USE_BDB=45+
- WITH_MYSQL should be replaced by USE_MYSQL

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>
The answer to the all-encompassing question on life, the universe and
everything: close windows and reboot.

Comment 2 Thomas Abthorpe 2008-07-24 13:41:23 UTC

On Wednesday 23 July 2008 19:08:13 Pav Lucistnik wrote:
> I fear some of the changes in this patch are incorrect:
>
> - no WITH_APACHE recognized in Mk/*, I think WITH_APACHE2 was correct
> - USE_BDB can grok values directly, ie. USE_BDB=3D42 instead of
> =A0 USE_BDB=3Dyes and WITH_BDB_VERSION=3D42. Also please mention ranges, =
ie.
> =A0 USE_BDB=3D45+
> - WITH_MYSQL should be replaced by USE_MYSQL

Thanks for the feedback, Pav. Looks that I need to wipe the sleep out of my=
=20
eyes before I hit the send button. Updated patch to follow.

Thomas

=2D-=20
Thomas Abthorpe		| FreeBSD Committer
tabthorpe@FreeBSD.org	| http://people.freebsd.org/~tabthorpe

Comment 3 Thomas Abthorpe 2008-07-24 15:57:34 UTC

Courtesy of Pav's feedback, and a third cup of coffee, please find attached 
replacement patch.


Thomas
-- 
Thomas Abthorpe		| FreeBSD Committer
tabthorpe@FreeBSD.org	| http://people.freebsd.org/~tabthorpe

Comment 4 Pav Lucistnik 2008-07-24 16:07:26 UTC

More complaining below

>  +		  <entry>If set, uses
>   		    <filename role="package">www/apache20</filename>
>  +		    as default.  It may be set with values
>  +		    such as 13, 20, 21 or 22.

"Uses www/apache20 as default." Default for what? Also, this accepts
ranges so please document these. Especially 2.0+ is useful.
(This accepts both 13, 20, and 1.3, 2.0, but I can't tell which is
supposed to be preferred.)

>  +		  <entry>If set, uses
>  +		    <filename role="package">databases/db41</filename>
>  +		    as default.  An associated variable,
>   		    <makevar>WITH_BDB_VER</makevar>, may be
>  +		    set to values such as 2, 3, 40, 41 or 42, 43, 44, 45
>  +		    46, or 47.  It is acceptable to set
>  +		    <makevar>USE_BDB</makevar> with the
>  +		    numeric values directly. 

Please remove mentions of WITH_BDB_VER completely, it's deprecated way
of doing things.

-- 
Pav Lucistnik <pav@oook.cz>
              <pav@FreeBSD.org>

Video games don't affect kids, I mean if Pac Man affected us as kids,
we'd all run around in a darkened room munching pills and listening to
repetitive music.
  -- Kristian Wilson, CEO at Nintendo Gaming Corporation Inc

Comment 5 Thomas Abthorpe 2008-07-24 19:11:05 UTC

With more feedback, and further deliberation, take a slightly different 
approach.

- Highlight defaults if MYSQL/BDB/APACHE options are unset
- Incorporate information regarding ports ranges for BDB/APACHE

Please find attached my current patch


Thomas
-- 
Thomas Abthorpe		| FreeBSD Committer
tabthorpe@FreeBSD.org	| http://people.freebsd.org/~tabthorpe

Comment 6 Pav Lucistnik 2008-07-24 19:47:05 UTC

State Changed
From-To: open->closed

Committed with modifications, thanks!

Comment 7 dfilter service 2008-07-24 19:50:08 UTC

pav         2008-07-24 18:50:00 UTC

  FreeBSD doc repository

  Modified files:
    en_US.ISO8859-1/books/porters-handbook book.sgml 
  Log:
  - Overhaul Makefile options section, and split USE_* flags into their own Using
    databases section under chapter 6.
  
  PR:             docs/125907 (based on)
  Submitted by:   tabthorpe
  
  Revision  Changes    Path
  1.939     +64 -48    doc/en_US.ISO8859-1/books/porters-handbook/book.sgml
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"