Bug 125921

Summary: lpd(8) talks about blocks in minfree while it is KB in reality
Product: Documentation Reporter: Andre.Albsmeier
Component: Books & ArticlesAssignee: Warren Block <wblock>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   

Description Andre.Albsmeier 2008-07-24 07:30:01 UTC
 
man 8 lpd says:

     The file minfree in each spool directory contains the number of disk
     blocks to leave free so that the line printer queue will not completely
     fill the disk.  The minfree file can be edited with your favorite text

but usr.sbin/lpr/lpd/recvjob.c doubles the value read from minfree
to convert kBytes into 512 byte blocks.

Fix: 

Replace blocks by kBytes in man page for lpd.
How-To-Repeat: 
1. man 8 lpd
2. grep minfree /usr/src/usr.sbin/lpr/lpd/recvjob.c
Comment 1 Warren Block freebsd_committer freebsd_triage 2012-08-13 15:54:54 UTC
Responsible Changed
From-To: freebsd-doc->wblock

Take.
Comment 2 dfilter service freebsd_committer freebsd_triage 2012-08-13 16:16:36 UTC
Author: wblock (doc committer)
Date: Mon Aug 13 15:16:25 2012
New Revision: 239233
URL: http://svn.freebsd.org/changeset/base/239233

Log:
  Correct description of minfree to kilobytes rather than blocks.
  
  PR:		125921
  Submitted by:	Andre Albsmeier <Andre.Albsmeier@siemens.com>
  MFC after:	3 days

Modified:
  head/usr.sbin/lpr/lpd/lpd.8

Modified: head/usr.sbin/lpr/lpd/lpd.8
==============================================================================
--- head/usr.sbin/lpr/lpd/lpd.8	Mon Aug 13 13:33:21 2012	(r239232)
+++ head/usr.sbin/lpr/lpd/lpd.8	Mon Aug 13 15:16:25 2012	(r239233)
@@ -152,7 +152,7 @@ machine with the printer.
 .Pp
 The file
 .Em minfree
-in each spool directory contains the number of disk blocks to leave free
+in each spool directory contains the number of kilobytes to leave free
 so that the line printer queue will not completely fill the disk.
 The
 .Em minfree
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 3 Warren Block freebsd_committer freebsd_triage 2012-08-13 16:21:52 UTC
State Changed
From-To: open->closed

Correction committed.  Thanks!
Comment 4 dfilter service freebsd_committer freebsd_triage 2012-08-20 17:31:35 UTC
Author: wblock (doc committer)
Date: Mon Aug 20 16:31:23 2012
New Revision: 239443
URL: http://svn.freebsd.org/changeset/base/239443

Log:
  MFC r239233:
  
  Correct description of minfree to kilobytes rather than blocks.
  
  PR:		125921
  Submitted by:	Andre Albsmeier <Andre.Albsmeier@siemens.com>

Modified:
  stable/9/usr.sbin/lpr/lpd/lpd.8
Directory Properties:
  stable/9/usr.sbin/lpr/lpd/   (props changed)

Modified: stable/9/usr.sbin/lpr/lpd/lpd.8
==============================================================================
--- stable/9/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:13:16 2012	(r239442)
+++ stable/9/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:31:23 2012	(r239443)
@@ -152,7 +152,7 @@ machine with the printer.
 .Pp
 The file
 .Em minfree
-in each spool directory contains the number of disk blocks to leave free
+in each spool directory contains the number of kilobytes to leave free
 so that the line printer queue will not completely fill the disk.
 The
 .Em minfree
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 5 dfilter service freebsd_committer freebsd_triage 2012-08-20 17:37:51 UTC
Author: wblock (doc committer)
Date: Mon Aug 20 16:37:41 2012
New Revision: 239444
URL: http://svn.freebsd.org/changeset/base/239444

Log:
  MFC r239233:
  
  Correct description of minfree to kilobytes rather than blocks.
  
  PR:		125921
  Submitted by:	Andre Albsmeier <Andre.Albsmeier@siemens.com>
  Approved by:	re (implicit)

Modified:
  releng/9.1/usr.sbin/lpr/lpd/lpd.8
Directory Properties:
  releng/9.1/usr.sbin/lpr/lpd/   (props changed)

Modified: releng/9.1/usr.sbin/lpr/lpd/lpd.8
==============================================================================
--- releng/9.1/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:31:23 2012	(r239443)
+++ releng/9.1/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:37:41 2012	(r239444)
@@ -152,7 +152,7 @@ machine with the printer.
 .Pp
 The file
 .Em minfree
-in each spool directory contains the number of disk blocks to leave free
+in each spool directory contains the number of kilobytes to leave free
 so that the line printer queue will not completely fill the disk.
 The
 .Em minfree
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 6 dfilter service freebsd_committer freebsd_triage 2012-08-20 17:39:10 UTC
Author: wblock (doc committer)
Date: Mon Aug 20 16:38:58 2012
New Revision: 239445
URL: http://svn.freebsd.org/changeset/base/239445

Log:
  MFC r239233:
  
  Correct description of minfree to kilobytes rather than blocks.
  
  PR:		125921
  Submitted by:	Andre Albsmeier <Andre.Albsmeier@siemens.com>

Modified:
  stable/8/usr.sbin/lpr/lpd/lpd.8
Directory Properties:
  stable/8/usr.sbin/lpr/lpd/   (props changed)

Modified: stable/8/usr.sbin/lpr/lpd/lpd.8
==============================================================================
--- stable/8/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:37:41 2012	(r239444)
+++ stable/8/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:38:58 2012	(r239445)
@@ -156,7 +156,7 @@ machine with the printer.
 .Pp
 The file
 .Em minfree
-in each spool directory contains the number of disk blocks to leave free
+in each spool directory contains the number of kilobytes to leave free
 so that the line printer queue will not completely fill the disk.
 The
 .Em minfree
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 7 dfilter service freebsd_committer freebsd_triage 2012-08-20 17:40:26 UTC
Author: wblock (doc committer)
Date: Mon Aug 20 16:40:15 2012
New Revision: 239446
URL: http://svn.freebsd.org/changeset/base/239446

Log:
  MFC r239233:
  
  Correct description of minfree to kilobytes rather than blocks.
  
  PR:		125921
  Submitted by:	Andre Albsmeier <Andre.Albsmeier@siemens.com>

Modified:
  stable/7/usr.sbin/lpr/lpd/lpd.8
Directory Properties:
  stable/7/usr.sbin/lpr/lpd/   (props changed)

Modified: stable/7/usr.sbin/lpr/lpd/lpd.8
==============================================================================
--- stable/7/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:38:58 2012	(r239445)
+++ stable/7/usr.sbin/lpr/lpd/lpd.8	Mon Aug 20 16:40:15 2012	(r239446)
@@ -156,7 +156,7 @@ machine with the printer.
 .Pp
 The file
 .Em minfree
-in each spool directory contains the number of disk blocks to leave free
+in each spool directory contains the number of kilobytes to leave free
 so that the line printer queue will not completely fill the disk.
 The
 .Em minfree
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"