Bug 12594
| Summary: | wrong sysctl descriptions | ||
|---|---|---|---|
| Product: | Base System | Reporter: | dada <dada> |
| Component: | kern | Assignee: | Garrett Wollman <wollman> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Unspecified | ||
| Hardware: | Any | ||
| OS: | Any | ||
|
Description
dada
1999-07-11 14:20:01 UTC
State Changed From-To: open->feedback Thanks for your feedback. Since you've put so much effort into reporting the problem, don't you want to go the extra step and submit a patch? You seem to have more than enough of a handle on the situation. Responsible Changed From-To: freebsd-bugs->sheldonh I'll take this one. Allright - here is a patch with (hopefully) somewhat clearer desriptions. Currently it is only for documentation of the code because those descriptions are not stored in any way (other than in the source code files) yet. (Since sysctl(8) has a documented ``-d'' Option, I assume that sysctl descriptions will be available in the future.) diff -u netinet/tcp_input.c /usr/src/sys/netinet/tcp_input.c --- netinet/tcp_input.c Thu Aug 19 07:22:12 1999 +++ /usr/src/sys/netinet/tcp_input.c Tue Aug 24 18:56:17 1999 @@ -82,7 +82,7 @@ static int log_in_vain = 0; SYSCTL_INT(_net_inet_tcp, OID_AUTO, log_in_vain, CTLFLAG_RW, - &log_in_vain, 0, "Log all incoming TCP connections"); + &log_in_vain, 0, "Log all refused TCP connections"); static int blackhole = 0; SYSCTL_INT(_net_inet_tcp, OID_AUTO, blackhole, CTLFLAG_RW, diff -u netinet/tcp_usrreq.c /usr/src/sys/netinet/tcp_usrreq.c --- netinet/tcp_usrreq.c Fri Jun 4 04:27:06 1999 +++ /usr/src/sys/netinet/tcp_usrreq.c Tue Aug 24 18:34:36 1999 @@ -701,10 +701,10 @@ */ u_long tcp_sendspace = 1024*16; SYSCTL_INT(_net_inet_tcp, TCPCTL_SENDSPACE, sendspace, CTLFLAG_RW, - &tcp_sendspace , 0, "Maximum outgoing TCP datagram size"); + &tcp_sendspace , 0, "TCP socket send buffer size"); u_long tcp_recvspace = 1024*16; SYSCTL_INT(_net_inet_tcp, TCPCTL_RECVSPACE, recvspace, CTLFLAG_RW, - &tcp_recvspace , 0, "Maximum incoming TCP datagram size"); + &tcp_recvspace , 0, "TCP socket receive buffer size"); /* * Attach TCP protocol to socket, allocating diff -u netinet/udp_usrreq.c /usr/src/sys/netinet/udp_usrreq.c --- netinet/udp_usrreq.c Thu Aug 19 07:22:12 1999 +++ /usr/src/sys/netinet/udp_usrreq.c Tue Aug 24 18:55:31 1999 @@ -76,7 +76,7 @@ static int log_in_vain = 0; SYSCTL_INT(_net_inet_udp, OID_AUTO, log_in_vain, CTLFLAG_RW, - &log_in_vain, 0, "Log all incoming UDP packets"); + &log_in_vain, 0, "Log all refused UDP connects"); static int blackhole = 0; SYSCTL_INT(_net_inet_udp, OID_AUTO, blackhole, CTLFLAG_RW, @@ -594,7 +594,7 @@ static u_long udp_recvspace = 40 * (1024 + sizeof(struct sockaddr_in)); SYSCTL_INT(_net_inet_udp, UDPCTL_RECVSPACE, recvspace, CTLFLAG_RW, - &udp_recvspace, 0, "Maximum incoming UDP datagram size"); + &udp_recvspace, 0, "UDP socket receive buffer size"); static int udp_abort(struct socket *so) Allright - here is a patch with (hopefully) somewhat clearer desriptions. Currently it is only for documentation of the code because those descriptions are not stored in any way (other than in the source code files) yet. (Since sysctl(8) has a documented ``-d'' Option, I assume that sysctl descriptions will be available in the future.) diff -u netinet/tcp_input.c /usr/src/sys/netinet/tcp_input.c --- netinet/tcp_input.c Thu Aug 19 07:22:12 1999 +++ /usr/src/sys/netinet/tcp_input.c Tue Aug 24 18:56:17 1999 @@ -82,7 +82,7 @@ static int log_in_vain = 0; SYSCTL_INT(_net_inet_tcp, OID_AUTO, log_in_vain, CTLFLAG_RW, - &log_in_vain, 0, "Log all incoming TCP connections"); + &log_in_vain, 0, "Log all refused TCP connections"); static int blackhole = 0; SYSCTL_INT(_net_inet_tcp, OID_AUTO, blackhole, CTLFLAG_RW, diff -u netinet/tcp_usrreq.c /usr/src/sys/netinet/tcp_usrreq.c --- netinet/tcp_usrreq.c Fri Jun 4 04:27:06 1999 +++ /usr/src/sys/netinet/tcp_usrreq.c Tue Aug 24 18:34:36 1999 @@ -701,10 +701,10 @@ */ u_long tcp_sendspace = 1024*16; SYSCTL_INT(_net_inet_tcp, TCPCTL_SENDSPACE, sendspace, CTLFLAG_RW, - &tcp_sendspace , 0, "Maximum outgoing TCP datagram size"); + &tcp_sendspace , 0, "TCP socket send buffer size"); u_long tcp_recvspace = 1024*16; SYSCTL_INT(_net_inet_tcp, TCPCTL_RECVSPACE, recvspace, CTLFLAG_RW, - &tcp_recvspace , 0, "Maximum incoming TCP datagram size"); + &tcp_recvspace , 0, "TCP socket receive buffer size"); /* * Attach TCP protocol to socket, allocating diff -u netinet/udp_usrreq.c /usr/src/sys/netinet/udp_usrreq.c --- netinet/udp_usrreq.c Thu Aug 19 07:22:12 1999 +++ /usr/src/sys/netinet/udp_usrreq.c Tue Aug 24 18:55:31 1999 @@ -76,7 +76,7 @@ static int log_in_vain = 0; SYSCTL_INT(_net_inet_udp, OID_AUTO, log_in_vain, CTLFLAG_RW, - &log_in_vain, 0, "Log all incoming UDP packets"); + &log_in_vain, 0, "Log all refused UDP connects"); static int blackhole = 0; SYSCTL_INT(_net_inet_udp, OID_AUTO, blackhole, CTLFLAG_RW, @@ -594,7 +594,7 @@ static u_long udp_recvspace = 40 * (1024 + sizeof(struct sockaddr_in)); SYSCTL_INT(_net_inet_udp, UDPCTL_RECVSPACE, recvspace, CTLFLAG_RW, - &udp_recvspace, 0, "Maximum incoming UDP datagram size"); + &udp_recvspace, 0, "UDP socket receive buffer size"); static int udp_abort(struct socket *so) On Tue, 24 Aug 1999 19:07:38 +0200, Martin Kammerhofer wrote: > Allright - here is a patch with (hopefully) somewhat clearer > desriptions. Thanks for following up on this. :-) > - &log_in_vain, 0, "Log all incoming TCP connections"); > + &log_in_vain, 0, "Log all refused TCP connections"); The word "refused" became confusing with the advent of integrated TCP Wrappers, even though folks in the know would realize that wrapping doesn't happen this deep. I'd prefer the new comment from src/etc/defaults/rc.conf: "Log TCP connection attempts to ports without listeners" > - &log_in_vain, 0, "Log all incoming UDP packets"); > + &log_in_vain, 0, "Log all refused UDP connects"); "Log UDP connection attempts to ports without listeners" For the rest of your descriptions, let's ask Garrett Wollman for his comments, since he's Mr Networking. Ciao, Sheldon. Not exactly _misleading_ descriptions, but _missing_ ones instead. Since it's so related I follow up to my original PR. --- /usr/src/sys/netinet/tcp_timer.c Wed Sep 1 19:02:52 1999 +++ ./tcp_timer.c Mon Sep 6 18:55:53 1999 @@ -85,15 +85,15 @@ int tcp_keepinit; SYSCTL_PROC(_net_inet_tcp, TCPCTL_KEEPINIT, keepinit, CTLTYPE_INT|CTLFLAG_RW, - &tcp_keepinit, 0, sysctl_msec_to_ticks, "I", ""); + &tcp_keepinit, 0, sysctl_msec_to_ticks, "I", "Timeout for connection attempts"); int tcp_keepidle; SYSCTL_PROC(_net_inet_tcp, TCPCTL_KEEPIDLE, keepidle, CTLTYPE_INT|CTLFLAG_RW, - &tcp_keepidle, 0, sysctl_msec_to_ticks, "I", ""); + &tcp_keepidle, 0, sysctl_msec_to_ticks, "I", "Idle time before keepalive probes begin"); int tcp_keepintvl; SYSCTL_PROC(_net_inet_tcp, TCPCTL_KEEPINTVL, keepintvl, CTLTYPE_INT|CTLFLAG_RW, - &tcp_keepintvl, 0, sysctl_msec_to_ticks, "I", ""); + &tcp_keepintvl, 0, sysctl_msec_to_ticks, "I", "Time between keepalive probes"); int tcp_delacktime; SYSCTL_PROC(_net_inet_tcp, TCPCTL_DELACKTIME, delacktime, Responsible Changed From-To: sheldonh->wollman Over to Mr Networking. State Changed From-To: feedback->open Duh, I should have changed state at the same time. It's not in feedback any more... Martin's provided diffs. :-) State Changed From-To: open->closed The person whom we consider responsible for this aspect of FreeBSD is unable to use of the GNATS Problem Report system. Please contact him directly at: Garrett Wollman <wollman@FreeBSD.org> Because this person is unable to commit any changes which your report may necessitate, he may send a new problem report himself, after reviewing yours. |
