Bug 126126

Summary: devel/bazaar-ng: Incorrect OPTIONS handling.
Product: Ports & Packages Reporter: UEMURA <UEMURA>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description UEMURA freebsd_committer freebsd_triage 2008-07-31 08:50:02 UTC 
devel/bazaar-ng/Makefile has the option SFTP and its default value is on. So the expression should be "!defined(WITHOUT_SFTP)" instead of "defined(WITH_SFTP)".

Fix: Patch attached with submission follows:
How-To-Repeat: cd /usr/ports/deve/bazaar-ng
make -DBATCH -DWITHOUT_SFTP
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-31 08:50:15 UTC 
Maintainer of devel/bazaar-ng,

Please note that PR ports/126126 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126126

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-07-31 08:50:16 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 fullermd 2008-07-31 09:42:13 UTC 
> If it contains a patch for an upgrade, an enhancement or a bug fix
> you agree on, reply to this email stating that you approve the patch
> and a committer will take care of it.

This looks fine to me.


On a side note, this REALLY should be explicitly documented in the
Porters Handbook.  The only mention of it is that the example shows
WITH/WITHOUT checking on the default off/on, but you'd never notice
that unless you already knew and were looking for it.    :(


-- 
Matthew Fuller     (MF4839)   |  fullermd@over-yonder.net
Systems/Network Administrator |  http://www.over-yonder.net/~fullermd/
           On the Internet, nobody can hear you scream.
Comment 4 Dmitry Marakasov freebsd_committer freebsd_triage 2008-07-31 22:25:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-07-31 22:35:10 UTC 
amdmi3      2008-07-31 21:34:55 UTC

  FreeBSD ports repository

  Modified files:
    devel/bazaar-ng      Makefile 
  Log:
  - Fix OPTIONS handling
  - Bump PORTREVISION
  
  PR:             ports/126126
  Submitted by:   UEMURA at FreeBSD dot org, Tetsuya <t_uemura at macome dot co dot jp>
  Approved by:    "Matthew D. Fuller" <fullermd at over-yonder dot net> (maintainer)
  Approved by:    miwi (mentor implicit)
  
  Revision  Changes    Path
  1.33      +2 -1      ports/devel/bazaar-ng/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Dmitry Marakasov freebsd_committer freebsd_triage 2008-07-31 22:46:26 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!