Bug 12618

Summary: poor trouble reporting by qpopper's pop_init.c
Product: Ports & Packages Reporter: mi+qpopper <mi+qpopper>
Component: Individual Port(s)Assignee: Andrey A. Chernov <ache>
Status: Closed FIXED    
Severity: Affects Only Me CC: qpopper
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description mi+qpopper 1999-07-13 04:30:01 UTC 
	When the  connecting client's IP address  is unresolvable, the
	popper logs the following:
	    (v2.53) Unable to get canonical name of client, err = 0

	The actual bug is, it uses errno instead of h_errno here.

	The improvement I added replaces  the numeric error codes with
	the actual error  string by hstrerror(3) in this  case, and by
	strerror(3) in several others in this file.

	It will also report the IP  address of the client now (already
	available in p->ipaddr).

Fix: The patch below (suitable  for patches/patch-am) addresses the
	bug and improves the error  reporting in the pop_init.c. Other
	files  can also  be modified  to report  an error  description
	instead of error code...

	The above quoted warning now looks as:
	(v2.53) Unable to get canonical name of client 10.10.0.10: Unknown host
How-To-Repeat: 
	Set up the popper, try to  fetch mail from a non-resolvable IP
	address. Watch the log.
Comment 1 Steve Price freebsd_committer freebsd_triage 1999-08-01 03:18:38 UTC 
Responsible Changed
From-To: freebsd-ports->ache

to maintainer.
Comment 2 Steve Price freebsd_committer freebsd_triage 1999-12-29 08:31:03 UTC 
State Changed
From-To: open->closed

Committed, thanks!