Bug 126441

Comment 1 Edwin Groothuis 2008-08-11 05:20:09 UTC

Maintainer of textproc/isearch,

Please note that PR ports/126441 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/126441

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org

Comment 2 Edwin Groothuis 2008-08-11 05:20:11 UTC

State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)

bah.. a minor fix ... I was including 
CFLAGS+= ${CXXFLAGS}
which, of course, adds CFLAGS twice.

sorry :(.



      Posta, news, sport, oroscopo: tutto in una sola pagina. 
Crea l'home page che piace a te!
www.yahoo.it/latuapagina

This may fix compilation, but have you tested the resulting program?  I'm 
concerned about removing the -fwritable-string option, which is described here:

Store string constants in the writable data  segment  and  don't uniquize  them. 
   This  is  for  compatibility with old programs which assume they can write 
into string constants.  `-traditional' also has this effect.  Writing  into 
string  constants is a very bad idea; "constants" should be constant.

The original developers must have added this argument for a reason.  I suspect 
there was some bad runtime behavior that required them to add this argument.

Pedro Giffuni wrote:
> bah.. a minor fix ... I was including 
> CFLAGS+= ${CXXFLAGS}
> which, of course, adds CFLAGS twice.
> 
> sorry :(.
> 
> 
> 
>       Posta, news, sport, oroscopo: tutto in una sola pagina. 
> Crea l'home page che piace a te!
> www.yahoo.it/latuapagina


-- 
Paul Marquis
pmarquis@pobox.com

It's untested.

I thought of the issue but then platforms other than linux don't seem to re=
quire that option. Please note that -fwritable-string appears deprecated in=
 gcc-3.4 and even then was basically a no-op:

http://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D18129

Pedro.=0A=0A=0A      Posta, news, sport, oroscopo: tutto in una sola pagina=
. =0ACrea l'home page che piace a te!=0Awww.yahoo.it/latuapagina

OK new approach ... I made the patch much smaller (it was difficult to get rid of ALL the deprecated C++ headers anyway).

We still use -fwritable-strings but at least now it's cleaner.

Pedro.


      Posta, news, sport, oroscopo: tutto in una sola pagina. 
Crea l'home page che piace a te!
www.yahoo.it/latuapagina

Since isearch is no longer maintained by the developers, I think 
requiring an older compiler is fine.  Ship it!  :-)

Pedro Giffuni wrote:
> OK new approach ... I made the patch much smaller (it was difficult to get rid of ALL the deprecated C++ headers anyway).
> 
> We still use -fwritable-strings but at least now it's cleaner.
> 
> Pedro.
> 
> 
>       Posta, news, sport, oroscopo: tutto in una sola pagina. 
> Crea l'home page che piace a te!
> www.yahoo.it/latuapagina


-- 
Paul Marquis
pmarquis@pobox.com

Thanks for the review.

While here ...

Use %%DOCSDIR%% in pkg-plist




      Posta, news, sport, oroscopo: tutto in una sola pagina. 
Crea l'home page che piace a te!
www.yahoo.it/latuapagina

Comment 9 Dmitry Marakasov 2008-09-01 16:11:35 UTC

Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.

Comment 10 Dmitry Marakasov 2008-09-02 21:39:28 UTC

State Changed
From-To: feedback->closed

Committed. Thanks!

Comment 11 dfilter service 2008-09-02 21:39:46 UTC

amdmi3      2008-09-02 20:39:26 UTC

  FreeBSD ports repository

  Modified files:
    textproc/isearch     Makefile pkg-plist 
    textproc/isearch/files patch-src::string.cxx 
  Added files:
    textproc/isearch/files patch-Makefile patch-doctype+Makefile 
                           patch-src+string::hxx 
                           patch-src::Iindex.cxx patch-src::fc.hxx 
                           patch-src::intlist.hxx 
                           patch-src::mergeunit.hxx 
                           patch-src::opstack.hxx 
  Log:
  - Fix build with gcc4.2 and amd64: remove -fwritable-strings.
  - Remove GNU_CONFIGURE since it was doing nothing: respect CXX CXXFLAGS.
  - Clean some warnings related to deprecated C++ headers.
  - Use %%DOCSDIR%% in pkg-plist
  
  PR:             126441
  Submitted by:   "Pedro F. Giffuni" <giffunip at tutopia dot com>
  Approved by:    Paul Marquis <pmarquis at pobox dot com> (maintainer)
  
  Revision  Changes    Path
  1.22      +6 -9      ports/textproc/isearch/Makefile
  1.1       +53 -0     ports/textproc/isearch/files/patch-Makefile (new)
  1.1       +20 -0     ports/textproc/isearch/files/patch-doctype+Makefile (new)
  1.1       +12 -0     ports/textproc/isearch/files/patch-src+string::hxx (new)
  1.1       +11 -0     ports/textproc/isearch/files/patch-src::Iindex.cxx (new)
  1.1       +12 -0     ports/textproc/isearch/files/patch-src::fc.hxx (new)
  1.1       +12 -0     ports/textproc/isearch/files/patch-src::intlist.hxx (new)
  1.1       +10 -0     ports/textproc/isearch/files/patch-src::mergeunit.hxx (new)
  1.1       +11 -0     ports/textproc/isearch/files/patch-src::opstack.hxx (new)
  1.2       +15 -3     ports/textproc/isearch/files/patch-src::string.cxx
  1.5       +5 -5      ports/textproc/isearch/pkg-plist
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"