Bug 126559

Summary: [PATCH] www/mod_security: add WITH_MLOGC knob, ModSecurity Log Collector
Product: Ports & Packages Reporter: Tomoyuki Sakurai <cherry>
Component: Individual Port(s)Assignee: Marcelo Araujo <araujo>
Status: Closed FIXED    
Severity: Affects Only Me CC: araujo
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
mod_security-2.5.5_3.patch none

Description Tomoyuki Sakurai 2008-08-16 02:30:01 UTC 
- add WITH_MLOGC knob
- add --build option to CONFIGURE_TARGET
- bump PORTREVISION

Port maintainer (araujo@FreeBSD.org) is cc'd.

Generated with FreeBSD Port Tools 0.77
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-08-16 02:30:12 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->araujo

Over to maintainer (via the GNATS Auto Assign Tool)
Comment 2 Tomoyuki Sakurai 2008-08-16 02:51:06 UTC 
Right after submission, I noticed that the port contains a bug.

Adding the extra file (${PREFIX}/bin/mlogc) to PLIST_FILES should not be
inside of ".if !defined(SKIP_RULES)".

It should be:

.if defined(WITH_MLOGC)
PLIST_FILES+=   ${PREFIX}/bin/mlogc
.endif
.if !defined(SKIP_RULES)
SUB_FILES+=     pkg-message.rules
PLIST_DIRS+=    ${APACHEETCDIR}/Includes/mod_security2/optional_rules
PLIST_DIRS+=    ${APACHEETCDIR}/Includes/mod_security2
...

Also, ModSecurity 2.5.6 accidentally dropped mlogc from the release tarball.
It will be back in the next release.

http://blog.modsecurity.org/2008/08/modsecurity-256.html

-- 
Tomoyuki Sakurai
Comment 3 Tomoyuki Sakurai 2008-08-16 04:23:51 UTC 
On Sat, Aug 16, 2008 at 10:51:06AM +0900, Tomoyuki Sakurai wrote:
> Adding the extra file (${PREFIX}/bin/mlogc) to PLIST_FILES should not be
> inside of ".if !defined(SKIP_RULES)".
> 
> It should be:
> 
> .if defined(WITH_MLOGC)
> PLIST_FILES+=   ${PREFIX}/bin/mlogc
> .endif

.if defined(WITH_MLOGC)
PLIST_FILES+=   bin/mlogc
.endif
-- 
Tomoyuki Sakurai
Comment 4 Marcelo Araujo freebsd_committer freebsd_triage 2008-10-19 15:09:09 UTC 
State Changed
From-To: open->feedback

Please, send again this patch with the correct modifications.
Comment 5 dfilter service freebsd_committer freebsd_triage 2008-12-08 17:05:40 UTC 
araujo      2008-12-08 17:05:30 UTC

  FreeBSD ports repository

  Modified files:
    www/mod_security     Makefile distinfo 
  Log:
  - Add WITH_MLOGC knob. [0]
  - Update to 2.5.7.
  
  PR:             ports/126559 [0]
  Submitted by:   Tomoyuki Sakurai <cherry@trombik.org>
  
  Revision  Changes    Path
  1.26      +26 -7     ports/www/mod_security/Makefile
  1.19      +3 -3      ports/www/mod_security/distinfo
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 6 Marcelo Araujo freebsd_committer freebsd_triage 2008-12-08 19:27:46 UTC 
State Changed
From-To: feedback->closed

Committed. Thanks!