Bug 126609

Summary: [vm] [patch] Unused variable `nosleepwithlocks' in sys/vm/uma_core.c
Product: Base System Reporter: Mateusz Guzik <mjguzik>
Component: kernAssignee: Antoine Brodin <antoine>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: 8.0-CURRENT   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Mateusz Guzik 2008-08-18 00:10:01 UTC 
Variable `nosleepwithlocks' is defined and controlled by sysctl debug.nosleepwithlocks, but not used. Support for it was removed in revision 1.142 -- from log message:

Remove uma_zalloc_arg() hack, which coerced M_WAITOK to M_NOWAIT when
allocations were made using improper flags in interrupt context.

Fix: Patch attached with submission follows:
Comment 1 Antoine Brodin freebsd_committer freebsd_triage 2008-08-18 17:25:53 UTC 
Responsible Changed
From-To: freebsd-bugs->antoine

Take.
Comment 2 dfilter service freebsd_committer freebsd_triage 2008-08-23 13:40:25 UTC 
antoine     2008-08-23 12:40:07 UTC

  FreeBSD src repository

  Modified files:
    sys/vm               uma_core.c 
  Log:
  SVN rev 182047 on 2008-08-23 12:40:07Z by antoine
  
  Remove unused variable nosleepwithlocks.
  
  PR:             126609
  Submitted by:   Mateusz Guzik
  MFC after:      1 month
  X-MFC:          to stable/7 only, this variable is still used in stable/6
  
  Revision  Changes    Path
  1.151     +0 -7      src/sys/vm/uma_core.c
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 3 Antoine Brodin freebsd_committer freebsd_triage 2008-08-23 13:52:06 UTC 
State Changed
From-To: open->patched

Patched in head.
Comment 4 dfilter service freebsd_committer freebsd_triage 2009-01-24 19:22:19 UTC 
Author: antoine
Date: Sat Jan 24 19:22:05 2009
New Revision: 187674
URL: http://svn.freebsd.org/changeset/base/187674

Log:
  MFC r182047 to stable/7:
    Remove unused variable nosleepwithlocks.
  
    PR:             126609
    Submitted by:   Mateusz Guzik
    MFC after:      1 month
    X-MFC:          to stable/7 only, this variable is still used in stable/6
  Reviewed by:	rwatson

Modified:
  stable/7/sys/   (props changed)
  stable/7/sys/contrib/pf/   (props changed)
  stable/7/sys/dev/ath/ath_hal/   (props changed)
  stable/7/sys/dev/cxgb/   (props changed)
  stable/7/sys/vm/uma_core.c

Modified: stable/7/sys/vm/uma_core.c
==============================================================================
--- stable/7/sys/vm/uma_core.c	Sat Jan 24 18:57:22 2009	(r187673)
+++ stable/7/sys/vm/uma_core.c	Sat Jan 24 19:22:05 2009	(r187674)
@@ -249,13 +249,6 @@ void uma_print_stats(void);
 static int sysctl_vm_zone_count(SYSCTL_HANDLER_ARGS);
 static int sysctl_vm_zone_stats(SYSCTL_HANDLER_ARGS);
 
-#ifdef WITNESS
-static int nosleepwithlocks = 1;
-#else
-static int nosleepwithlocks = 0;
-#endif
-SYSCTL_INT(_debug, OID_AUTO, nosleepwithlocks, CTLFLAG_RW, &nosleepwithlocks,
-    0, "Convert M_WAITOK to M_NOWAIT to avoid lock-held-across-sleep paths");
 SYSINIT(uma_startup3, SI_SUB_VM_CONF, SI_ORDER_SECOND, uma_startup3, NULL);
 
 SYSCTL_PROC(_vm, OID_AUTO, zone_count, CTLFLAG_RD|CTLTYPE_INT,
_______________________________________________
svn-src-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/svn-src-all
To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"
Comment 5 Antoine Brodin freebsd_committer freebsd_triage 2009-01-24 19:41:58 UTC 
State Changed
From-To: patched->closed

Patch committed in head and stable/7, thanks for the report!