Bug 126672
| Summary: | [patch] devel/viewvc: correct dependency for mod_python | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Eygene Ryabinkin <rea-fbsd> |
| Component: | Individual Port(s) | Assignee: | Philip M. Gollucci <pgollucci> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | CC: | pgollucci |
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-ports-bugs->pgollucci Over to maintainer (via the GNATS Auto Assign Tool) Only change is that should be ${LOCALBASE}
not ${PREFIX}
--
------------------------------------------------------------------------
Philip M. Gollucci (philip@ridecharge.com)
o:703.549.2050x206
Senior System Admin - Riderway, Inc.
http://riderway.com / http://ridecharge.com
1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C
Work like you don't need the money,
love like you'll never get hurt,
and dance like nobody's watching.
Philip, good day.
Wed, Aug 20, 2008 at 07:32:56AM -0400, Philip M. Gollucci wrote:
> Only change is that should be ${LOCALBASE} not ${PREFIX}
Hmm, yes, you're right. I always messing these two.
It is a bit strange the portlint had not catched this, I will
try to take a look.
Thanks for the correction!
--
Eygene
_ ___ _.--. #
\`.|\..----...-'` `-._.-'_.-'` # Remember that it is hard
/ ' ` , __.--' # to read the on-line manual
)/' _/ \ `-_, / # while single-stepping the kernel.
`-'" `"\_ ,_.-;_.-\_ ', fsc/as #
_.-'_./ {_.' ; / # -- FreeBSD Developers handbook
{_.-``-' {_/ #
pgollucci 2008-08-20 12:23:56 UTC
FreeBSD ports repository
Modified files:
devel/viewvc Makefile
Log:
Fix typo in previous commit breaking the dependency on mod_python3:
Needs an absolute path
PR: ports/126672
Submitted by: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
Approved by: gabor (mentor, implicit)
Revision Changes Path
1.32 +1 -1 ports/devel/viewvc/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed New port added, with minor changes. Thanks! |
Port for viewvc specifies non-absolute path for the mod_python dependency. This means that bsd.port.mk will try to search for an executable with such name. And this will fail in almost any sane case, since libexec/apache22/mod_python.so is shared library and isn't in the PATH. So the port will try to build the mod_python port as a dependency. And if mod_python is already installed, the build will fail loudly: ----- ===> Installing for viewvc-1.0.5_3 ===> viewvc-1.0.5_3 depends on file: /usr/local/bin/python2.5 - found ===> viewvc-1.0.5_3 depends on file: /usr/local/lib/python2.5/site-packages/svn/__init__.py - found ===> viewvc-1.0.5_3 depends on ***>>> executable <<<***: libexec/apache22/mod_python.so - not found ===> Verifying install for libexec/apache22/mod_python.so in /usr/ports/www/mod_python3 ===> Installing for mod_python-3.3.1_1 ===> mod_python-3.3.1_1 depends on file: /usr/local/bin/python2.5 - found ===> mod_python-3.3.1_1 depends on file: /usr/local/sbin/apxs - found ===> Generating temporary packing list ===> Checking if www/mod_python3 already installed ===> mod_python-3.3.1_1 is already installed You may wish to ``make deinstall'' and install this port again by ``make reinstall'' to upgrade it properly. If you really wish to overwrite the old port of www/mod_python3 without deleting it first, set the variable "FORCE_PKG_REGISTER" in your environment or the "make install" command line. *** Error code 1 Stop in /usr/ports/www/mod_python3. *** Error code 1 Stop in /usr/ports/devel/viewvc. # ls -l /usr/local/libexec/apache22/mod_python.so -rwxr-xr-x 1 root wheel 163833 Aug 19 21:26 /usr/local/libexec/apache22/mod_python.so ----- Fix: The following patch will fix the things: It works for me without problems: ----- ===> Installing for viewvc-1.0.5_3 ===> viewvc-1.0.5_3 depends on file: /usr/local/bin/python2.5 - found ===> viewvc-1.0.5_3 depends on file: /usr/local/lib/python2.5/site-packages/svn/__init__.py - found ===> viewvc-1.0.5_3 depends on file: /usr/local/libexec/apache22/mod_python.so - found ===> viewvc-1.0.5_3 depends on file: /usr/local/sbin/apxs - found ===> Generating temporary packing list [...] -------m4HzGISILmZ0cRccyoGTK6GDeveHPnXSEK8lUsIn28q4WL5D Content-Type: text/plain; name="viewvc-correct-dependency-path.diff" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="viewvc-correct-dependency-path.diff" Dependency for mod_python should contain fully-qualified path to make the build system treat it as file and not as an executable. --- Makefile.orig 2008-08-20 10:26:55.000000000 +0400 +++ Makefile 2008-08-20 10:28:23.000000000 +0400 @@ -49,7 +49,7 @@ .endif .if defined(WITH_MODPYTHON3) -RUN_DEPENDS+= ${APACHEMODDIR}/mod_python.so:${PORTSDIR}/www/mod_python3 +RUN_DEPENDS+= ${PREFIX}/${APACHEMODDIR}/mod_python.so:${PORTSDIR}/www/mod_python3 .endif # This feature is a clone of the Mozilla Project's Bonsai database. How-To-Repeat: Install mod_python, try to install viewvc when WITH_MODPYTHON3 is set.