Bug 126876
| Summary: | www/xpi-adblock - Makefile.xpi's xpi-gen gets the wrong id sometimes | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Lapo Luchini <lapo> | ||||||
| Component: | Individual Port(s) | Assignee: | Philip M. Gollucci <pgollucci> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | CC: | lapo | ||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
Responsible Changed From-To: freebsd-ports-bugs->infofarmer Over to maintainer (via the GNATS Auto Assign Tool) Responsible Changed From-To: infofarmer->freebsd-ports-bugs Maintainer was reset. Responsible Changed From-To: freebsd-ports-bugs->chinsan I'll take this. Responsible Changed From-To: chinsan->miwi Pass to new maintainer State Changed From-To: open->closed fixed in my local tree. a headup for testing will be come to the end of next week. Thanks for your report. I can still reproduce this:
% cd /usr/ports/www/xpi-stumbleupon
% sudo make xpi-gen | fgrep ID
XPI_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
% cd ../xpi-searchstatus
% sudo make xpi-gen | fgrep ID
XPI_ID={ec8030f7-c20a-464f-9b0e-13a3a9e97384}
The ID that is found seems to be the one referring to Firefox versions
that are compatible with the plugin, not the version of the plugin.
The attached patch fixed the problem for my XPI ports. Some extensions use a different XML namespace, the attached patch accounts for that. State Changed From-To: closed->open re-open, was never actually committed Responsible Changed From-To: miwi->pgollucci I will take it pgollucci 2010-09-08 00:44:49 UTC
FreeBSD ports repository
Modified files:
www/xpi-adblock Makefile.xpi
Log:
- Fix XPI_ID generation when the tag might spam multiple lines [1]
- Do not install meta data (META-INF) since its not needed
allow for xpi-post-extract to still work in xpi-* ports [2]
PR: ports/126876 [1], ports/150327 [2]
Submitted by: Lapo Luchini <lapo@lapo.it> [1], [2] tweaked by me
Approved by: maintainer timeout (miwi; ~1 yr) [1] [2]
Tested by: P6 TB Run, RideCharge TB Run
Revision Changes Path
1.24 +11 -3 ports/www/xpi-adblock/Makefile.xpi
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed Committed, Thanks! |
ports/www/xpi-adblock/Makefile.xpi's xpi-gen target gets the first id from install.rdf, which is not always the correct one. Fix: The grep at line 195 can't solve the problem by itself, because the tag may be split over multiple line, so it's necessary to use sed or awk to choose the correct id. How-To-Repeat: cd /usr/ports/www/xpi-stumbleupon make xpi-gen produces: {ec8030f7-c20a-464f-9b0e-13a3a9e97384} should produce: {AE93811A-5C9A-4d34-8462-F7B864FC4696}