Bug 127120

Summary:	[uart] uart module doesn't load on amd64
Product:	Base System	Reporter:	Paul B. Mahol <onemda>
Component:	kern	Assignee:	Marcel Moolenaar <marcel>
Status:	Closed FIXED
Severity:	Affects Only Me
Priority:	Normal
Version:	Unspecified
Hardware:	Any
OS:	Any

Description Paul B. Mahol 2008-09-05 19:40:02 UTC

uart module doesnt build on amd64:

uart_dev_quicc.c: In function 'quicc_getc':
uart_dev_quicc.c:221: warning: cast to pointer from integer of different size
uart_dev_quicc.c: In function 'quicc_bus_receive':                               uart_dev_quicc.c:436: warning: cast to pointer from integer of different size    uart_dev_quicc.c: In function 'quicc_bus_transmit':                              uart_dev_quicc.c:480: warning: cast to pointer from integer of different size


On i386 uart module does build but can't be loaded:

link_elf: symbol uart_quicc_class undefined

Because uart_dev_quicc.c is not listed in module Makefile.

Comment 1 Volker Werth freebsd_committer

2008-10-05 19:21:54 UTC

State Changed
From-To: open->feedback

Paul, 

you've filed some warnings but I don't see a reason for a compiler 
error. As I've rebuild an 8-CURRENT system a few days ago, 
I'm pretty sure there're currently no build errors (for GENERIC kernel). 

Please try to update your current sources (remember -CURRENT is 
a moving target) and try to recompile kernel. For problems 
with -CURRENT, it's best to post a message into current@ instead 
of filing a PR. 

If your problem is still valid, we need to get more information from 
you (not just some compiler warnings).

Comment 2 Volker Werth freebsd_committer

2008-10-05 19:21:54 UTC

Responsible Changed
From-To: freebsd-bugs->vwe

Paul, 

you've filed some warnings but I don't see a reason for a compiler 
error. As I've rebuild an 8-CURRENT system a few days ago, 
I'm pretty sure there're currently no build errors (for GENERIC kernel). 

Please try to update your current sources (remember -CURRENT is 
a moving target) and try to recompile kernel. For problems 
with -CURRENT, it's best to post a message into current@ instead 
of filing a PR. 

If your problem is still valid, we need to get more information from 
you (not just some compiler warnings).

Comment 3 Volker Werth freebsd_committer

2008-10-06 18:30:31 UTC

Responsible Changed
From-To: vwe->marcel


Over to maintainer. 
Marcel: Paul told me, you're already aware of that problem and have a fix for it. 
Still I think problems like these are better handled in the ML. 
Also filing a PR without willing to give any technical details (even 
when queried for afterwards) is 'suboptimal'.

Comment 4 Marcel Moolenaar freebsd_committer

2008-11-22 21:25:08 UTC

State Changed
From-To: feedback->closed

The problem has been resolved by fixing the code so that it 
can be compiled on amd64 and also to include the QUICC 
backend in the kernel module.