Bug 127464
| Summary: | www/apache13* knobs not honoring "YES" | ||
|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Aleksandr Stankevic <alex> |
| Component: | Individual Port(s) | Assignee: | Munechika Sumikawa <sumikawa> |
| Status: | Closed FIXED | ||
| Severity: | Affects Only Me | ||
| Priority: | Normal | ||
| Version: | Latest | ||
| Hardware: | Any | ||
| OS: | Any | ||
Responsible Changed From-To: freebsd-ports-bugs->ache Over to maintainer (via the GNATS Auto Assign Tool) ache 2008-09-23 12:34:38 UTC
FreeBSD ports repository
Modified files:
www/apache13 Makefile
Log:
Don't check value for WITH_/WITHOUT_ vars, especially for "yes"
Just relay on they are set.
PR: 127464
Revision Changes Path
1.183 +6 -7 ports/www/apache13/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Responsible Changed From-To: ache->freebsd-ports-bugs Fixed in apache13, returned to the pool for other apaches Responsible Changed From-To: freebsd-ports-bugs->dinoex It appears the next ports are dinoex's. dinoex 2008-09-28 07:42:24 UTC
FreeBSD ports repository
Modified files:
www/apache13-modssl Makefile
Log:
- drop case senstive checks
PR: 127464
Revision Changes Path
1.190 +4 -4 ports/www/apache13-modssl/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Responsible Changed From-To: dinoex->sumikawa Please check ports/www/apache13+ipv6 sumikawa 2008-09-30 03:13:43 UTC
FreeBSD ports repository
Modified files:
www/apache13+ipv6 Makefile
www/apache13+ipv6/files patch-ag
Log:
- Don't check value for WITH_/WITHOUT_ vars, especially for "yes"
Just relay on they are set.
- sync with www/apache13.
PR: 127464
Revision Changes Path
1.60 +6 -7 ports/www/apache13+ipv6/Makefile
1.4 +20 -16 ports/www/apache13+ipv6/files/patch-ag
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: open->closed I must be last guy. Commited, thanks. |
www/apache13* doesn't honor "YES" for WITH_* stuff: > grep -R "== yes" /usr/ports/www/apache13/ /usr/ports/www/apache13/Makefile:.if defined(WITHOUT_APACHE_EXPAT) && ${WITHOUT_APACHE_EXPAT} == yes /usr/ports/www/apache13/Makefile:.if defined(WITH_APACHE_SUEXEC) && ${WITH_APACHE_SUEXEC} == yes /usr/ports/www/apache13/Makefile:.if defined(WITH_APACHE_PERF_TUNING) && ${WITH_APACHE_PERF_TUNING} == yes So, setting i.e. WITH_APACHE_SUEXEC="YES" won't work, it has to be WITH_APACHE_SUEXEC=yes There are also same problems for other www/apache13-* ports (apache13-modssl and friends) Fix: make it honor the 'yes' flag case-insensitively or don't look at the YES at all, and only look if it's defined? How-To-Repeat: cd /usr/ports/www/apache13/ make WITH_APACHE_SUEXEC=YES find ./ -name suexec #doesn't find anything make clean make WITH_APACHE_SUEXEC=yes find ./ -name suexec # find a compiled suexec binary