Bug 127504

Summary: [patch] multimedia/mplayer depends on liblzo but needs liblzo2
Product: Ports & Packages Reporter: Eugene Grosbein <ports>
Component: Individual Port(s)Assignee: Dmitry Marakasov <amdmi3>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
file.diff none

Description Eugene Grosbein 2008-09-20 09:40:01 UTC 
	The port multimedia/mplayer may optionally depend on external
	LZO library (WITH_LIBLZO). It checks for liblzo.so.1
	and installs it with archivers/lzo port if needed.
	However, mplayer's configure scripts looks for liblzo2.so.
	So, if there is lzo2 installed, mplayer compiles with lzo2
	dependancy but records lzo. Then 'pkg_create -R -b mplayer-0.99.11_5'
	creates a set of packages needed to install and run mplayer
	but pkg_add mplayer-0.99.11_5.tbz installs liblzo and not liblzo2
	and mplayer binary fails to link with liblzo2.so it needs
	(when it is missing on targed host where mplayer is installed
	using created set of packages).

	If lzo2 is not installed when mplayers builds, its configure
	script skips support for external LZO library but dependency
	on liblzo is recorded, however.

How-To-Repeat: 
	Make sure there is no liblzo2 installed, build mplayer via port
	and see that its binary does not link with lzo library.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-09-20 09:40:06 UTC 
Maintainer of multimedia/mplayer,

Please note that PR ports/127504 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/127504

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-09-20 09:40:08 UTC 
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-21 22:34:06 UTC 
Responsible Changed
From-To: freebsd-ports-bugs->amdmi3

I'll take it.
Comment 4 Thomas E. Zander 2008-09-22 08:08:49 UTC 
This is correct. We can commit this patch.

Thank you,
Riggs
Comment 5 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-22 10:41:36 UTC 
State Changed
From-To: feedback->open

Maintainer approved.
Comment 6 dfilter service freebsd_committer freebsd_triage 2008-09-23 19:56:13 UTC 
amdmi3      2008-09-23 18:56:08 UTC

  FreeBSD ports repository

  Modified files:
    multimedia/mplayer   Makefile Makefile.options 
  Log:
  - Depend on correct version of lzo
  
  PR:             127504
  Submitted by:   Eugene Grosbein <eu at grosbein dot pp dot ru>
  Approved by:    Thomas E. Zander <riggs at rrr dot de> (maintainer)
  
  Revision  Changes    Path
  1.176     +1 -1      ports/multimedia/mplayer/Makefile
  1.6       +1 -1      ports/multimedia/mplayer/Makefile.options
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 7 Dmitry Marakasov freebsd_committer freebsd_triage 2008-09-23 22:08:20 UTC 
State Changed
From-To: open->closed

Committed. Thanks!