Bug 127524
| Summary: | multimedia/mplayer lacks dependencies on Xv and dga | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Christoph Mallon <christoph.mallon> | ||||||
| Component: | Individual Port(s) | Assignee: | Dmitry Marakasov <amdmi3> | ||||||
| Status: | Closed FIXED | ||||||||
| Severity: | Affects Only Me | ||||||||
| Priority: | Normal | ||||||||
| Version: | Latest | ||||||||
| Hardware: | Any | ||||||||
| OS: | Any | ||||||||
| Attachments: |
|
||||||||
|
Description
Christoph Mallon
2008-09-21 16:30:03 UTC
Maintainer of multimedia/mplayer,
Please note that PR ports/127524 has just been submitted.
If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.
The full text of the PR can be found at:
http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/127524
--
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
State Changed From-To: open->feedback Awaiting maintainers feedback (via the GNATS Auto Assign Tool) Responsible Changed From-To: freebsd-ports-bugs->amdmi3 I'll take it. State Changed From-To: feedback->open Maintainer approved via private email. State Changed From-To: open->feedback Oops, changed wrong PR. Sounds like a reasonable suggestions. I'll look into it. Riggs Attached patch introduces dependencies on commonly available video output drivers on FreeBSD. They are integrated in the OPTIONS framework. Can you please verify if that resolves the issue? Riggs Thomas E. Zander wrote:
> Attached patch introduces dependencies on commonly available video
> output drivers on FreeBSD.
> They are integrated in the OPTIONS framework.
>
> Can you please verify if that resolves the issue?
This looks good. after applying the patch and rebuilding mplayer the
dependency list is much longer and includes the libraries, which were
missing before. Though, I did not try to uninstall libraries and check,
if they are automatically installed, but I suspect the bsd.xorg.mk magic
works. Thanks for tackling this issue.
A minor point: Can the message about switches, which are not available
via OPTIONS, be removed?
Christoph
On Sun, 05. Oct 2008, at 16:28 +0200, Christoph Mallon wrote according to [Re: ports/127524: multimedia/mplayer lacks dependencies on Xv and dga]: > This looks good. > Though, I did not try to uninstall libraries and check, > if they are automatically installed, but I suspect the bsd.xorg.mk magic > works. Yeah, don't worry about that. bsd.xorg.mk handles it nicely as you pointed out. > A minor point: Can the message about switches, which are not available > via OPTIONS, be removed? May I ask why this is an issue? It simply is the case that we have additional switches which are used very rarely and are therefore not included in OPTIONS. I would like to make sure the admin person installing the port knows about their existence. Riggs -- - "[...] I talked to the computer at great length and -- explained my view of the Universe to it" said Marvin. --- And what happened?" pressed Ford. ---- "It committed suicide." said Marvin. Thomas E. Zander wrote:
>> A minor point: Can the message about switches, which are not available
>> via OPTIONS, be removed?
>
> May I ask why this is an issue?
> It simply is the case that we have additional switches which are used
> very rarely and are therefore not included in OPTIONS. I would like to
> make sure the admin person installing the port knows about their
> existence.
I see no reason to /not/ include all switches in OPTIONS.
Christoph
On Mon, 06. Oct 2008, at 12:55 +0200, Christoph Mallon wrote
according to [Re: ports/127524: multimedia/mplayer lacks dependencies on Xv and dga]:
> I see no reason to /not/ include all switches in OPTIONS.
I do.
First, look at the CPU features options. For the vast majority of
people this just lengthens the list in OPTIONS. It is only in very rare
situations or when someone wants to test/benchmark something that this
is needed.
Second: The OPTIONS framework gives you WITH_ and WITHOUT_.
It does not give you something like
WITH_DVD_DEVICE=/dev/acd2
We can't possibly have an OPTIONS list with all possible device
enumerations and language list.
This is why I chose to have some knobs outside the OPTIONS.
Riggs
--
- "[...] I talked to the computer at great length and
-- explained my view of the Universe to it" said Marvin.
--- And what happened?" pressed Ford.
---- "It committed suicide." said Marvin.
This fails to build WITHOUT_X11: http://people.freebsd.org/~amdmi3/mplayer-nox11-0.99.11_8.log -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru On Fri, 10. Oct 2008, at 18:40 +0400, Dmitry Marakasov wrote
according to [Re: ports/127524: multimedia/mplayer lacks dependencies on Xv and dga]:
> This fails to build WITHOUT_X11:
> http://people.freebsd.org/~amdmi3/mplayer-nox11-0.99.11_8.log
True.
Should be fixed in the attached revision of the patch.
Riggs
amdmi3 2008-10-11 13:45:57 UTC
FreeBSD ports repository
Modified files:
multimedia/mplayer Makefile
Log:
- Add dependencies on Xorg libs and corresponding OPTIONS
PR: 127524
Submitted by: Christoph Mallon <christoph dot mallon at gmx dot de>
Patch by: "Thomas E. Zander" <riggs at rrr dot de> (maintainer)
Revision Changes Path
1.178 +35 -5 ports/multimedia/mplayer/Makefile
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
State Changed From-To: feedback->closed Committed. Thanks! |
