Bug 127995

Summary: net/isc-dhcp30-server creates a user/group with dynamic UID/GID (>= 1000)
Product: Ports & Packages Reporter: Ashish Shukla <wahjava>
Component: Individual Port(s)Assignee: Josh Paetzel <jpaetzel>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Latest   
Hardware: Any   
OS: Any   
Attachments:
Description Flags
isc-dhcp30-server.diff
none
isc-dhcp31-server.diff
none
isc-dhcp30-server.diff
none
dhcp31-server.patch none

Description Ashish Shukla 2008-10-10 12:30:01 UTC
When installing port net/isc-dhcp3-server, a user (with a dynamic UID) gets 
created on installation, which in my opinion is incorrect. The expected behavior
is to reserve a UID/GID for the dhcpd in ${PORTSDIR}/{U,G}IDs files.

How-To-Repeat: Execute following on a root shell:

# make -C /usr/ports/net/isc-dhcp3-server config install

In the above command make sure DHCP_PARANOIA config option is set. And now do:

# getent passwd dhcpd
dhcpd:*:1002:1002:DHCP Daemon:/nonexistent:/usr/sbin/nologin

If you get UID, and GID > 1000, then this is problem.
Comment 1 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-10 12:30:11 UTC
Maintainer of net/isc-dhcp3-server,

Please note that PR ports/127995 has just been submitted.

If it contains a patch for an upgrade, an enhancement or a bug fix
you agree on, reply to this email stating that you approve the patch
and a committer will take care of it.

The full text of the PR can be found at:
    http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/127995

-- 
Edwin Groothuis via the GNATS Auto Assign Tool
edwin@FreeBSD.org
Comment 2 Edwin Groothuis freebsd_committer freebsd_triage 2008-10-10 12:30:13 UTC
State Changed
From-To: open->feedback

Awaiting maintainers feedback (via the GNATS Auto Assign Tool)
Comment 3 Stefan Walter freebsd_committer freebsd_triage 2008-12-17 16:55:34 UTC
Responsible Changed
From-To: freebsd-ports-bugs->stefan

Take.
Comment 4 Stefan Walter freebsd_committer freebsd_triage 2008-12-18 14:35:45 UTC
Hi Joerg,

there is a problem report waiting for your feedback as the maintainer of
net/isc-dhcp30-server. Could you have a look and let us know what you
think of it? The PR's contents can be found at [1].

Regards,
Stefan

[1]: http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/127995
Comment 5 Stefan Walter freebsd_committer freebsd_triage 2009-01-08 19:46:45 UTC
Hi Ashish,

can you please send a patch for the changes you propose to be made to
net/isc-dhcp30-server?

Regards,
Stefan
Comment 6 Stefan Walter freebsd_committer freebsd_triage 2009-01-11 15:48:20 UTC
Feedback received by submitter: 

----- Forwarded message from Ashish SHUKLA <wahjava@gmail.com> -----

From: Ashish SHUKLA <wahjava@gmail.com>
Subject: Re: ports/127995: net/isc-dhcp30-server creates a user/group with
	dynamic UID/GID (>= 1000)
Organization: /\/0/\/3
To: Stefan Walter <stefan@FreeBSD.org>
Date: Sat, 10 Jan 2009 02:53:49 +0530

> can you please send a patch for the changes you propose to be made to
> net/isc-dhcp30-server?

Ofcourse, I'll send a patch, but it'll take few days (< 6), as I'm bit busy 
with the work these days.

-- 
Ashish SHUKLA

----- End forwarded message -----
Comment 7 Ashish Shukla 2009-01-12 08:31:22 UTC
Hi Stefan,

> can you please send a patch for the changes you propose to be made to
> net/isc-dhcp30-server?

Try the attached patch. I'm registering no. 136 to be used as the UID
and GID for dhcpd. The attached diff fixes the dhcpd rc.d script which
is responsible for creating the user. The attached diff also patches
${PORTSDIR}/{U,G}IDs files. I think similar diff needs to be created for
other *dhcpd* ports too.

> Regards,
> Stefan

HTH
-- 
Ashish SHUKLA
Comment 8 dfilter service freebsd_committer freebsd_triage 2009-01-12 15:18:09 UTC
stefan      2009-01-12 15:17:52 UTC

  FreeBSD ports repository

  Modified files:
    .                    UIDs GIDs 
    net/isc-dhcp30-server Makefile 
    net/isc-dhcp30-server/files isc-dhcpd.in 
  Log:
  Register a fixed UID/GID for the user 'dhcpd' and use that instead of a
  dynamically chosen one.
  
  PR:             127995
  Submitted by:   Ashish Shukla <wahjava@gmail.com>
  Approved by:    maintainer timeout (3 months)
  
  Revision  Changes    Path
  1.67      +2 -1      ports/GIDs
  1.77      +2 -1      ports/UIDs
  1.129     +1 -1      ports/net/isc-dhcp30-server/Makefile
  1.6       +7 -6      ports/net/isc-dhcp30-server/files/isc-dhcpd.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 9 Stefan Walter freebsd_committer freebsd_triage 2009-01-28 12:27:19 UTC
State Changed
From-To: feedback->patched

net/isc-dhcp30-server has been patched, the other versions should be changed 
accordingly.
Comment 10 Stefan Walter freebsd_committer freebsd_triage 2009-02-27 13:31:06 UTC
Responsible Changed
From-To: stefan->freebsd-ports-bugs

I currently don't have the time to handle this.
Comment 11 Mark Linimon freebsd_committer freebsd_triage 2009-05-12 23:44:43 UTC
Responsible Changed
From-To: freebsd-ports-bugs->jpaetzel

Over to new maintainer.
Comment 12 Pav Lucistnik freebsd_committer freebsd_triage 2009-09-20 21:17:55 UTC
State Changed
From-To: patched->open

New patches received
Comment 13 Josh Paetzel freebsd_committer freebsd_triage 2010-06-26 08:50:26 UTC
Updated patch, tested in tb, waiting for commit approval to check in.

-- 
Thanks,

Josh Paetzel
Comment 14 Ashish Shukla 2010-06-26 09:15:13 UTC
Josh Paetzel writes:
> Updated patch, tested in tb, waiting for commit approval to check in.


Better late than never ;)

-- 
Ashish SHUKLA

Sent via Gnus from GNU Emacs

P.S. I'm also a committer (freebsd.org!ashish) now.
Comment 15 dfilter service freebsd_committer freebsd_triage 2010-06-26 14:16:18 UTC
jpaetzel    2010-06-26 13:16:09 UTC

  FreeBSD ports repository

  Modified files:
    net/isc-dhcp31-server/files isc-dhcpd.in 
  Log:
  Long overdue change to get dhcp31 to match dhcp30's behavior of using a static UID/GID
  
  PR:     ports/127995
  Submitted by:   Ashish Shukla <wahjava@gmail.com>
  Approved by:    itetcu@ (mentor)
  Feature safe:   yes
  
  Revision  Changes    Path
  1.10      +7 -6      ports/net/isc-dhcp31-server/files/isc-dhcpd.in
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Comment 16 Josh Paetzel freebsd_committer freebsd_triage 2010-06-26 14:16:28 UTC
State Changed
From-To: open->closed

Committed, thanks!