Bug 12825

Summary: doscmd build depends on X
Product: Base System Reporter: Doug <Doug>
Component: binAssignee: Sheldon Hearn <sheldonh>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description Doug 1999-07-27 01:00:01 UTC
	A make world build stops in the doscmd directory when there
is no X (specifically no X libs/headers) installed on the system.

Fix: 

Unknown
How-To-Repeat: 
	cd /usr/src/usr.bin/doscmd && make
Comment 1 Tim Vanderhoek 1999-07-27 02:18:27 UTC
On Mon, Jul 26, 1999 at 04:56:58PM -0700, Doug@gorean.org wrote:
> 
> 	A make world build stops in the doscmd directory when there
> is no X (specifically no X libs/headers) installed on the system.

Um, are you sure?  Do you have some left-over /usr/X11R6 directories?
When did it start doing this?


-- 
This is my .signature which gets appended to the end of my messages.
Comment 2 Doug 1999-07-27 06:36:37 UTC
Tim Vanderhoek wrote:
> 
> On Mon, Jul 26, 1999 at 04:56:58PM -0700, Doug@gorean.org wrote:
> >
> >       A make world build stops in the doscmd directory when there
> > is no X (specifically no X libs/headers) installed on the system.
> 
> Um, are you sure?  Do you have some left-over /usr/X11R6 directories?

	Hrrmmm... maybe that's the problem. I had installed X, then realized it
was the 3.3.3.1 version still and cd 'cd /usr/X11R6 && rm -r *'. I'll try
again with no X directory at all. 

Sorry for the confusion,

Doug
Comment 3 Sheldon Hearn freebsd_committer freebsd_triage 1999-07-27 10:51:18 UTC
State Changed
From-To: open->feedback

This one's bitten me before. Can you confirm that it was pilot error and 
not some other problem? 

Comment 4 Doug 1999-07-27 20:18:40 UTC
On Tue, 27 Jul 1999 sheldonh@FreeBSD.org wrote:

> State-Changed-From-To: open->feedback
> This one's bitten me before. Can you confirm that it was pilot error and
> not some other problem?

	I don't see how it could be pilot error to have an empty
/usr/X11R6 directory. :) In any case, a quick look at the Makefile for
doscmd shows this:

.if exists(${X11BASE}/include/X11/X.h) && exists(${XLIBDIR}/libX11.a)
CFLAGS+= -I. -I${X11BASE}/include -DDISASSEMBLER
LDADD= -L${XLIBDIR} -lX11
DPADD= ${XLIBDIR}/libX11.a
.else
CFLAGS+= -I. -DDISASSEMBLER -DNO_X
.endif

When it failed for me the error was directly related to lX11, so I'd say
that this is a genuine bug given that I didn't have either one of those
files (although I did have an empty /usr/X11R6 directory) and yet make
tried to link against libX11 anyway. 

	I vaguely remember having some odd problems with the .if exists
test a while back when I was working on a port, but I'm far from a make
expert, so I couldn't really say where to look for this. 

Doug
Comment 5 Sheldon Hearn 1999-07-27 20:51:04 UTC
On Tue, 27 Jul 1999 12:18:40 MST, Doug wrote:

> 	I don't see how it could be pilot error to have an empty
> /usr/X11R6 directory. :) In any case, a quick look at the Makefile for
> doscmd shows this:

I'll create an empty /usr/X11R6 before my next buildworld and see what
happens. It'll have to wait 'til then unless you can provide error
output.

Ciao,
Sheldon.
Comment 6 Sheldon Hearn freebsd_committer freebsd_triage 1999-07-29 20:10:53 UTC
Responsible Changed
From-To: freebsd-bugs->sheldonh

I'll be looking into this soon if Doug doesn't provide feedback. 

Comment 7 Sheldon Hearn 1999-08-12 03:38:20 UTC
On Mon, 26 Jul 1999 16:56:58 MST, Doug@gorean.org wrote:

>  When it failed for me the error was directly related to lX11, so I'd say
>  that this is a genuine bug given that I didn't have either one of those
>  files (although I did have an empty /usr/X11R6 directory) and yet make
>  tried to link against libX11 anyway. 

Okay, I've tried this with an empty /usr/X11R6 and the build behaves as
expected, in that everything is compiled with -DNO_X . I'm out of ideas,
unless you can send the exact error message(s) you got?

Ciao,
Sheldon.
Comment 8 Doug 1999-08-12 04:06:57 UTC
Sheldon Hearn wrote:
> 
> On Mon, 26 Jul 1999 16:56:58 MST, Doug@gorean.org wrote:
> 
> >  When it failed for me the error was directly related to lX11, so I'd say
> >  that this is a genuine bug given that I didn't have either one of those
> >  files (although I did have an empty /usr/X11R6 directory) and yet make
> >  tried to link against libX11 anyway.
> 
> Okay, I've tried this with an empty /usr/X11R6 and the build behaves as
> expected, in that everything is compiled with -DNO_X . I'm out of ideas,
> unless you can send the exact error message(s) you got?

 2# cd /usr
 3# mv X11R6 X11R6-real
 4# mkdir X11R6
 5# cd src/usr.bin/doscmd
 6# make
make: don't know how to make /usr/X11R6/include/X11/Xlib.h. Stop

	That's with -current cvsup'ed about 2 hours ago. When I ran into this
problem during the world build originally I got the same error message,
this is just the fastest way to reproduce it. 

Doug
Comment 9 Sheldon Hearn 1999-08-12 06:25:50 UTC
Hi Doug,

Okay, I seem to have the same .mk files as you do. I've just blown away
obj, cleaned out crufty objects from my source tree and am conducting a
buildworld, in the hopes that it'll trigger the problem you see.

If I can't see it, you'll probably want to ask in a public forum whether
anyone else sees this.

Ciao,
Sheldon.
Comment 10 Sheldon Hearn 1999-08-12 09:18:30 UTC
On Thu, 12 Aug 1999 07:25:50 +0200, Sheldon Hearn wrote:

> If I can't see it, you'll probably want to ask in a public forum whether
> anyone else sees this.

Just thought I'd drop you a quick note to let you know that the
buildworld went through without a hickup.

Let me know if you find out what's causing your problem.

Later,
Sheldon.
Comment 11 Sheldon Hearn freebsd_committer freebsd_triage 1999-10-01 13:02:03 UTC
State Changed
From-To: feedback->closed

I can't duplicate this with CURRENT, nor with STABLE, so I'm closing 
this until more evidence is uncovered. :-(