Bug 128384
| Summary: | new port x11/xorg-minimal | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Ports & Packages | Reporter: | Eitan Adler <eadler> | ||||||||||
| Component: | Individual Port(s) | Assignee: | Stefan Walter <stefan> | ||||||||||
| Status: | Closed FIXED | ||||||||||||
| Severity: | Affects Only Me | ||||||||||||
| Priority: | Normal | ||||||||||||
| Version: | Latest | ||||||||||||
| Hardware: | Any | ||||||||||||
| OS: | Any | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Eitan Adler
2008-10-26 02:50:01 UTC
Hi Eitan, you submitted a Makefile only. Could you please send a followup to this PR with a complete shar file of the new port attached? (See [1] for details.) Thanks and regards, Stefan [1]: http://www.de.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-submitting.html The shar file is attached. It includes pkg-plist, pkg-descr, and Makefile. Do I need anything else? -- Eitan Adler GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 I found a minor mistake: Change This is a metaport for least amount of X.Org needed to run a xorg server. to This is a metaport for least amount of ports needed to run a X.Org server. -- Eitan Adler GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 Eitan Adler, 21.12.08, 16:17h CET:
> The shar file is attached. It includes pkg-plist, pkg-descr, and
> Makefile. Do I need anything else?
No. Actually, just Makefile and pkg-descr, since pkg-plist is empty,
anyway. However, all your RUN_DEPENDS are looking for the same executable
(xf86-video-vesa). Please correct those and send me an updated shar file.
Regards,
Stefan
Stefan Walter wrote:
<snip> However, all your RUN_DEPENDS are looking for the same executable
> (xf86-video-vesa). Please correct those and send me an updated shar file.
I completely forgot about that.
Attached is updated shar file.
--
Eitan Adler
GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1
Responsible Changed From-To: freebsd-ports-bugs->stefan Take. Hi Eitan,
Eitan Adler, 22.12.08, 05:07h CET:
> Stefan Walter wrote:
> <snip> However, all your RUN_DEPENDS are looking for the same executable
> > (xf86-video-vesa). Please correct those and send me an updated shar file.
> I completely forgot about that.
> Attached is updated shar file.
Hm...it doesn't quite work the way you did it. There are still a few
issues with the RUN_DEPENDS - suggestions:
- xf86-video-vesa: Look for
"${LOCALBASE}/lib/xorg/modules/drivers/vesa_drv.so", not
"xf86-video-vesa".
- xf86-input-mouse and xf86-input-keyboard: Prefix the path with
"${LOCALBASE}".
- With the fonts packages:
- ${FONTSDIR} is not defined. Use "${LOCALBASE}/lib/X11/fonts".
- Instead of ${NONEXISTENT}, please use a path to a file installed by
the port.
Furthermore:
- I don't think CONFLICTS is needed here at all. CONFLICTS is used when
two ports can't be installed at the same time because they both install
files with the same name in the same place. With xorg-minimal, it
probably wouldn't make much sense to install it along with the normal
xorg port, but it's possible and I see no reason to forbid it.
- When assigning variable values, please use a tab after the '=', not
spaces.
Also, please test your new port before submitting it. That way you should
be able to catch most issues earlier. (In this case, at least the ones
with the RUN_DEPENDS.)
Regards,
Stefan
> Also, please test your new port before submitting it. How? I tested with make install and make index and portlint. None of these turned up any errors. Regarding the font-misc-misc I chose a file at random as none of them seem to be a primary file in the port. Attached is new Makefile (index is being tested again right now). > Regards, > Stefan Thanks -- Eitan Adler GNU Key fingerprint: 2E13 BC16 5F54 0FBD 62ED 42B6 B65F 24AB E9C2 CCD1 stefan 2008-12-27 13:11:29 UTC
FreeBSD ports repository
Modified files:
x11 Makefile
Added files:
x11/xorg-minimal Makefile pkg-descr
Log:
Add xorg-minimal, a meta-port for installing only the necessary part of the
X.Org distribution.
PR: 128384
Submitted by: Eitan Adler <EitanAdlerList@gmail.com>
Revision Changes Path
1.698 +1 -0 ports/x11/Makefile
1.1 +39 -0 ports/x11/xorg-minimal/Makefile (new)
1.1 +6 -0 ports/x11/xorg-minimal/pkg-descr (new)
_______________________________________________
cvs-all@freebsd.org mailing list
http://lists.freebsd.org/mailman/listinfo/cvs-all
To unsubscribe, send any mail to "cvs-all-unsubscribe@freebsd.org"
Hi, Eitan Adler, 23.12.08, 03:20h CET: > > Also, please test your new port before submitting it. > How? > I tested with make install and make index and portlint. None of these > turned up any errors. The recommended testing procedure is described at [1], and using portlint is fine. Hm...I don't have the logs any more, but 'make install' didn't work with the version you initially submitted since the RUN_DEPENDS were wrong. The dependencies were never satisfied, so the installation was aborted. > Regarding the font-misc-misc I chose a file at random as none of them > seem to be a primary file in the port. Looks good. > Attached is new Makefile (index is being tested again right now). Thanks! I just committed the new port with a couple of minor/cosmetic changes: - Indentation of the RUN_DEPENDS. - I changed PKGNAMESUFFIX from '-lite' to '-minimal'; I assumed that it should be the latter since it's in the directory's name, too. Thanks for your contribution! Regards, Stefan [1]: http://www.freebsd.org/doc/en_US.ISO8859-1/books/porters-handbook/porting-testing.html State Changed From-To: open->closed New port committed, thanks! |