Bug 12844

Summary: sysinstall disk label editor needs to right justify Size field, or use GB
Product: Base System Reporter: mkc <mkc>
Component: binAssignee: Brian Somers <brian>
Status: Closed FIXED    
Severity: Affects Only Me    
Priority: Normal    
Version: Unspecified   
Hardware: Any   
OS: Any   

Description mkc 1999-07-27 22:30:00 UTC
sysinstall's disk label editor's size field is overflowing when size is
greater than 9999MB, which is now a reality.  But there are (potentially)
free spaces to the left if the Mount field is not filled.  Alternatively,
start using GB instead of MB.  Below is an example of what just happened
when I added an 18 GB and 2 9 GB disks:

                         FreeBSD Disklabel Editor

Disk: da2       Partition name: da2s1   Free: 0 blocks (0MB)
Disk: da3       Partition name: da3s1   Free: 0 blocks (0MB)
Disk: da4       Partition name: da4s1   Free: 0 blocks (0MB)

Part    Mount            Size Newfs   Part    Mount            Size Newfs
----    -----            ---- -----   ----    -----            ---- -----
da2s1e  /remote/16     17366MBUFS Y
da3s1e  /remote/17     8682MB UFS Y
da4s1e  /remote/18     8682MB UFS Y  






The following commands are valid here (upper or lower case):
C = Create      D = Delete         M = Mount pt. W = Write
N = Newfs Opts  T = Newfs Toggle   U = Undo      Q = Finish
A = Auto Defaults for all!

Use F1 or ? to get more help, arrow keys to select.

Fix: 

Right justify rather than left justify, or use GB rather than MB
when value exceeds 9999 MB.
How-To-Repeat: Add another 18 GB disk.
Comment 1 Sheldon Hearn freebsd_committer freebsd_triage 1999-07-28 14:20:25 UTC
Responsible Changed
From-To: freebsd-bugs->jkh

Hand over to Mr Sysinstall. *duck* 
Comment 2 Brian Somers freebsd_committer freebsd_triage 1999-07-28 21:48:08 UTC
Responsible Changed
From-To: jkh->brian

I'll commit patches from joe@uk.FreeBSD.org if jkh doesn't mind 
Comment 3 Brian Somers freebsd_committer freebsd_triage 1999-07-29 09:44:17 UTC
State Changed
From-To: open->closed

Fixed in -current.  I'll MFC in a few days.